From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.tuxdriver.com (charlotte.tuxdriver.com [70.61.120.58]) by dpdk.org (Postfix) with ESMTP id 2927DCD4F for ; Fri, 1 May 2015 20:48:24 +0200 (CEST) Received: from hmsreliant.think-freely.org ([2001:470:8:a08:7aac:c0ff:fec2:933b] helo=localhost) by smtp.tuxdriver.com with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.63) (envelope-from ) id 1YoFz1-000681-Aw; Fri, 01 May 2015 14:48:21 -0400 Date: Fri, 1 May 2015 14:48:13 -0400 From: Neil Horman To: Matthew Hall Message-ID: <20150501184813.GC27756@hmsreliant.think-freely.org> References: <20150501164512.GB27756@hmsreliant.think-freely.org> <20150501173108.GA24714@mhcomputing.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150501173108.GA24714@mhcomputing.net> User-Agent: Mutt/1.5.23 (2014-03-12) X-Spam-Score: -2.9 (--) X-Spam-Status: No Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] GitHub sandbox for the DPDK community X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 01 May 2015 18:48:24 -0000 On Fri, May 01, 2015 at 10:31:08AM -0700, Matthew Hall wrote: > On Fri, May 01, 2015 at 12:45:12PM -0400, Neil Horman wrote: > > Yes, but as you said above, using a web browser doesn't make reviewing patches > > faster. In fact, I would assert that it slows the process down, as it prevents > > quick, easy command line access to patch review (as you have with a properly > > configured MUA). That seems like we're going in the opposite direction of at > > least one problem we would like to solve. > > Normally I'm a big command-line supporter. However I have found reviewing > patches by email for me is about the most painful workflow. > > The emails are pages and pages. > So collapse the quoted text (see below) > The replies from commenters are buried in the walls of text. > Again, collapse the text, many MUA's let you do that, its not a feature unique to github. > Replies to replies keep shifting farther off the edge of the screen. The code > gets weirder and weirder to try to read. > Text Collapse will reformat that for you. > Quickly reading over the patchset by scrolling through to get the flavor of > it, to see if I'm qualified to review it, and look at the parts I actually > know about is much harder. > Thats what the origional post is for, no? Look at that to determine if you are qualified to read it. > I can go to one place to see every candidate patchset out there, the GH Pull > Request page. Then I can just sync up the branch and test it on my own systems > to see if it works, not just try to read it. > how is that different from a mailing list? both let you search for posts, and both allow you to sync git branches (github via git remote/pull, mailing list via git am) > Github automatically minimizes old comments that are already fixed, so they > don't keep consuming space and mental bandwidth from the review. An MUA can do that too. IIRC evolution and thunderbird both have collapse features. I'm sure others do too. > > All in all, I'd be able to review more DPDK patches faster with the GH > interface than having them in the mailing list. > > Matthew. >