DPDK patches and discussions
 help / color / mirror / Atom feed
From: Neil Horman <nhorman@tuxdriver.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: dev@dpdk.org, Stephen Hemminger <shemming@brocade.com>
Subject: Re: [dpdk-dev] [PATCH 1/3] pci: allow access to PCI config space
Date: Thu, 7 May 2015 06:35:45 -0400	[thread overview]
Message-ID: <20150507103545.GA336@hmsreliant.think-freely.org> (raw)
In-Reply-To: <1430948228-1426-2-git-send-email-stephen@networkplumber.org>

On Wed, May 06, 2015 at 02:37:06PM -0700, Stephen Hemminger wrote:
> From: Stephen Hemminger <shemming@brocade.com>
> 
> Some drivers need ability to access PCI config (for example for power
> management). This adds an abstraction to do this; only implemented
> on Linux, but should be possible on BSD.
> 
You didn't test this with shared libraries.  Not having added these new symbols
to the version map will cause a build break.  Also I think you need to implement
this on BSD, its not ok to just have bnx2x break on non-linux platforms.

Thanks
Neil

  reply	other threads:[~2015-05-07 10:35 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-06 21:37 [dpdk-dev] [PATCH 0/3] bnx2x: poll mode driver Stephen Hemminger
2015-05-06 21:37 ` [dpdk-dev] [PATCH 1/3] pci: allow access to PCI config space Stephen Hemminger
2015-05-07 10:35   ` Neil Horman [this message]
2015-05-06 21:37 ` [dpdk-dev] [PATCH 2/3] bnx2x: new poll mode driver Stephen Hemminger
2015-05-06 21:37 ` [dpdk-dev] [PATCH 3/3] bnx2x: enable BNX2X " Stephen Hemminger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150507103545.GA336@hmsreliant.think-freely.org \
    --to=nhorman@tuxdriver.com \
    --cc=dev@dpdk.org \
    --cc=shemming@brocade.com \
    --cc=stephen@networkplumber.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).