From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.tuxdriver.com (charlotte.tuxdriver.com [70.61.120.58]) by dpdk.org (Postfix) with ESMTP id 8240612A8 for ; Thu, 7 May 2015 12:35:54 +0200 (CEST) Received: from hmsreliant.think-freely.org ([2001:470:8:a08:7aac:c0ff:fec2:933b] helo=localhost) by smtp.tuxdriver.com with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.63) (envelope-from ) id 1YqJ9i-0000Qv-VO; Thu, 07 May 2015 06:35:52 -0400 Date: Thu, 7 May 2015 06:35:45 -0400 From: Neil Horman To: Stephen Hemminger Message-ID: <20150507103545.GA336@hmsreliant.think-freely.org> References: <1430948228-1426-1-git-send-email-stephen@networkplumber.org> <1430948228-1426-2-git-send-email-stephen@networkplumber.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1430948228-1426-2-git-send-email-stephen@networkplumber.org> User-Agent: Mutt/1.5.23 (2014-03-12) X-Spam-Score: -2.9 (--) X-Spam-Status: No Cc: dev@dpdk.org, Stephen Hemminger Subject: Re: [dpdk-dev] [PATCH 1/3] pci: allow access to PCI config space X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 07 May 2015 10:35:54 -0000 On Wed, May 06, 2015 at 02:37:06PM -0700, Stephen Hemminger wrote: > From: Stephen Hemminger > > Some drivers need ability to access PCI config (for example for power > management). This adds an abstraction to do this; only implemented > on Linux, but should be possible on BSD. > You didn't test this with shared libraries. Not having added these new symbols to the version map will cause a build break. Also I think you need to implement this on BSD, its not ok to just have bnx2x break on non-linux platforms. Thanks Neil