From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 28B2B569A for ; Thu, 7 May 2015 18:05:32 +0200 (CEST) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga101.fm.intel.com with ESMTP; 07 May 2015 09:04:31 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.13,384,1427785200"; d="scan'208";a="490642369" Received: from bricha3-mobl3.ger.corp.intel.com ([10.237.220.85]) by FMSMGA003.fm.intel.com with SMTP; 07 May 2015 09:04:29 -0700 Received: by (sSMTP sendmail emulation); Thu, 07 May 2015 17:04:28 +0025 Date: Thu, 7 May 2015 17:04:28 +0100 From: Bruce Richardson To: Marc Sune Message-ID: <20150507160428.GB5972@bricha3-MOBL3> References: <1431012951-6423-1-git-send-email-bruce.richardson@intel.com> <554B8890.3070502@bisdn.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <554B8890.3070502@bisdn.de> Organization: Intel Shannon Ltd. User-Agent: Mutt/1.5.23 (2014-03-12) Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [RFC PATCH 0/2] Move PMDs out of lib directory X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 07 May 2015 16:05:33 -0000 On Thu, May 07, 2015 at 05:45:20PM +0200, Marc Sune wrote: > > > On 07/05/15 17:35, Bruce Richardson wrote: > >The "lib" directory is getting very crowded, with both general libs and > >poll mode drivers in it. This patch set proposes to move the PMDs out of the > >lib folder and to put them in a separate "pmds" folder. This should help > >with code browse-ability as the number of libs, and pmds increases. > > > >Comments or objections? > > > >Bruce Richardson (2): > > pmds: Use relative rather than absolute paths > > pmds: move pmds from lib to separate pmd dir > > > > create mode 100644 pmds/librte_pmd_xenvirt/rte_mempool_gntalloc.c > > create mode 100644 pmds/librte_pmd_xenvirt/rte_xen_lib.c > > create mode 100644 pmds/librte_pmd_xenvirt/rte_xen_lib.h > > create mode 100644 pmds/librte_pmd_xenvirt/virtio_logs.h > > create mode 100644 pmds/librte_pmd_xenvirt/virtqueue.h > > > > But at the end they are also libraries. What about something like: > > * libs/core <= fundamental libraries (eal, mbuf rings...) > * libs/pmds <= all pmds > > And other feature-group oriented, higher level lib, directories (not sure > right now how to better classify them right now): > * libs/processing <= packet processing > * libs/utils > ... > Yes, they are all just libs, so we could make "pmds" be a sub-dir of the lib folder. I prefer the shorter path myself, but if others want a multi-level hierarchy it's no big deal. For the other libs, I'm not sure we need to split them up, and I also think that trying to divide them into categories - and what those categories should be could - cause endless discussion. However, maybe I'm overly pessimistic... :-) /Bruce