From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-000f0801.pphosted.com (mx0a-000f0801.pphosted.com [67.231.144.122]) by dpdk.org (Postfix) with ESMTP id B29BB56AB for ; Fri, 8 May 2015 04:58:57 +0200 (CEST) Received: from pps.filterd (m0048193.ppops.net [127.0.0.1]) by mx0a-000f0801.pphosted.com (8.14.7/8.14.7) with SMTP id t4822A1q010507; Thu, 7 May 2015 19:58:55 -0700 Received: from hq1wp-exchub01.corp.brocade.com ([144.49.131.13]) by mx0a-000f0801.pphosted.com with ESMTP id 1u8h520atj-1 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NOT); Thu, 07 May 2015 19:58:55 -0700 Received: from HQ1WP-EXMB12.corp.brocade.com (10.70.20.186) by HQ1WP-EXCHUB01.corp.brocade.com (10.70.36.99) with Microsoft SMTP Server (TLS) id 14.3.123.3; Thu, 7 May 2015 19:58:55 -0700 Received: from urahara (10.72.48.66) by HQ1WP-EXMB12.corp.brocade.com (10.70.20.186) with Microsoft SMTP Server (TLS) id 15.0.1044.25; Thu, 7 May 2015 19:58:54 -0700 Date: Thu, 7 May 2015 19:58:59 -0700 From: Stephen Hemminger To: Cunming Liang Message-ID: <20150507195859.45fd2353@urahara> In-Reply-To: <1430804386-28949-4-git-send-email-cunming.liang@intel.com> References: <1425012976-10173-1-git-send-email-cunming.liang@intel.com> <1430804386-28949-1-git-send-email-cunming.liang@intel.com> <1430804386-28949-4-git-send-email-cunming.liang@intel.com> Organization: Brocade MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.72.48.66] X-ClientProxiedBy: hq1wp-excas12.corp.brocade.com (10.70.38.22) To HQ1WP-EXMB12.corp.brocade.com (10.70.20.186) X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:5.14.151, 1.0.33, 0.0.0000 definitions=2015-05-08_01:2015-05-07,2015-05-08,1970-01-01 signatures=0 X-Proofpoint-Spam-Details: rule=notspam policy=default score=33 spamscore=33 suspectscore=1 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=7.0.1-1402240000 definitions=main-1505080024 X-Mailman-Approved-At: Sun, 10 May 2015 14:55:47 +0200 Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v7 03/10] eal/linux: add API to set rx interrupt event monitor X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 08 May 2015 02:58:58 -0000 On Tue, 5 May 2015 13:39:39 +0800 Cunming Liang wrote: > + bytes_read = read(fd, &buf, bytes_read); > + if (bytes_read < 0) > + RTE_LOG(ERR, EAL, "Error reading from file " > + "descriptor %d: %s\n", fd, > + strerror(errno) The read could be interrupted (EINTR) or there could be a race (EWOULDBLOCK). In those cases the code should not log anything.