From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <bruce.richardson@intel.com> Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id D07CB11C5 for <dev@dpdk.org>; Wed, 13 May 2015 15:40:55 +0200 (CEST) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga102.jf.intel.com with ESMTP; 13 May 2015 06:40:52 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.13,420,1427785200"; d="scan'208";a="694292646" Received: from bricha3-mobl3.ger.corp.intel.com ([10.237.220.50]) by orsmga001.jf.intel.com with SMTP; 13 May 2015 06:40:49 -0700 Received: by (sSMTP sendmail emulation); Wed, 13 May 2015 14:40:48 +0025 Date: Wed, 13 May 2015 14:40:48 +0100 From: Bruce Richardson <bruce.richardson@intel.com> To: Thomas Monjalon <thomas.monjalon@6wind.com> Message-ID: <20150513134048.GA13080@bricha3-MOBL3> References: <1431012951-6423-1-git-send-email-bruce.richardson@intel.com> <1431450315-13179-1-git-send-email-bruce.richardson@intel.com> <555254E5.7050906@6wind.com> <20150513090109.GB12276@bricha3-MOBL3> <555352A7.6090408@6wind.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <555352A7.6090408@6wind.com> Organization: Intel Shannon Ltd. User-Agent: Mutt/1.5.23 (2014-03-12) Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH 00/19] Move PMDs to drivers directory X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK <dev.dpdk.org> List-Unsubscribe: <http://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <http://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Wed, 13 May 2015 13:40:56 -0000 On Wed, May 13, 2015 at 03:33:27PM +0200, Thomas Monjalon wrote: > 2015-05-13 11:01, Bruce Richardson: > > On Tue, May 12, 2015 at 09:30:45PM +0200, Thomas Monjalon wrote: > >> 2015-05-12 19:04, Bruce Richardson: > >>> drivers/e1000/e1000/e1000_hw.h | 1026 ++++ > >> > >> As explained in a previous comment, > >> http://dpdk.org/ml/archives/dev/2015-May/017509.html > >> I think this path would be better: > >> drivers/net/e1000/base/e1000_hw.h > > > > Two reasons why I didn't create the "net" subfolder: > > 1. I initally forgot to consider it :-( > > 2. While we may at some future point have other device driver types, are we really > > needing to start categorising PMDs at this point? > > > > As for the base driver part, I was viewing that as a something that should be > > a separate patch set, since it's unrelated to moving things to the drivers > > subdir. > > I understand your points and I partially agree. > However, file moves may be perturbing because it change habits > and may complicate a bit the git history browsing. > So I think it's better to minimize such moves and do altogether. > Ok. I'll see about renaming the base code directories as part of the overall move process [Unless there are objections from any of the driver maintainers]. As for drivers vs drivers/net, I suppose there is no real difference in what the path actually is, so I can make that change too. However, I still think I prefer the shorter path. Anyone else any opinions on this [before I start reworking this again]? /Bruce