From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ig0-f174.google.com (mail-ig0-f174.google.com [209.85.213.174]) by dpdk.org (Postfix) with ESMTP id E99B75697 for ; Sat, 16 May 2015 01:55:46 +0200 (CEST) Received: by igbyr2 with SMTP id yr2so10058737igb.0 for ; Fri, 15 May 2015 16:55:46 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-type:content-transfer-encoding; bh=5poSuVKMhVuTGtUfQiZs94A9a6KIWopGhKjza4oyqs8=; b=OGukqHcuryUQlsPKsq66ZgFZg9vs2XjUh9Oodh5yyJ+HvMtkxaUIhzxp8qDsnWI79f fSBZCgLS6lYhiTViwycuACphMludGrIkwxQ3ZxWdJhev6Rzf3hiHH0IzTSYVfs0yZVGH fy7HF3NHGS1Rzf9cMl0OyC3pbGZcUuZiP9Qbkgs2VYpCCv6/wfhIveKWEBH+XFWgBc/1 ThTSQPF1U0aP+p3V0KgjstPC4PfS6O6jquIqnLSNvfcn6LCjNnMzqLFJhsZ3rIYUFn/+ ww5yb2EMZGtMyKihUjJELpvdaYRCLMl58N32uVc3J+jqBmH4wAjPZrfZ0GSoH7hfaIC2 3Aog== X-Gm-Message-State: ALoCoQnXLDcidcW41HigyWWHpSuPfLM8CgAQ60qzDlRqWrZxxI3XHvG40TywdXzWEDHCcY9zkEXX X-Received: by 10.68.69.105 with SMTP id d9mr22491473pbu.144.1431734146355; Fri, 15 May 2015 16:55:46 -0700 (PDT) Received: from urahara (static-50-53-82-155.bvtn.or.frontiernet.net. [50.53.82.155]) by mx.google.com with ESMTPSA id pp6sm2945191pbb.17.2015.05.15.16.55.45 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 15 May 2015 16:55:46 -0700 (PDT) Date: Fri, 15 May 2015 16:55:48 -0700 From: Stephen Hemminger To: Jijiang Liu Message-ID: <20150515165548.4e88b744@urahara> In-Reply-To: <1431670141-7835-2-git-send-email-jijiang.liu@intel.com> References: <1431670141-7835-1-git-send-email-jijiang.liu@intel.com> <1431670141-7835-2-git-send-email-jijiang.liu@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH 01/10] examples/tep_termination:initialize the VXLAN sample X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 15 May 2015 23:55:47 -0000 On Fri, 15 May 2015 14:08:52 +0800 Jijiang Liu wrote: > + while (dev_ll != NULL) { > + /*get virtio device ID*/ Really minor style nit. Please put whitespace in comments. Do this instead. /* get virtio device ID */ Also, the name virtio is confusing since it can be confused with KVM virtio.