Re: [dpdk-dev] [PATCH 3/5] ixgbe: raise priority of significant events

[Bruce Richardson <bruce.richardson@intel.com>]

On Fri, May 15, 2015 at 10:08:25AM -0700, Stephen Hemminger wrote:
> The driver does lots of logging at INFO level, but some setup
> events are significant and should be at NOTICE or ERR level
> since they are problems that user should see.
> 
> Also never put tabs in log messages because they get mangled
> by syslog processing.
> 
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>

Acked-by: Bruce Richardson <bruce.richardson@intel.com>

One small nit below.

> ---
>  lib/librte_pmd_ixgbe/ixgbe_ethdev.c | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/lib/librte_pmd_ixgbe/ixgbe_ethdev.c b/lib/librte_pmd_ixgbe/ixgbe_ethdev.c
> index fa335f4..7e75382 100644
> --- a/lib/librte_pmd_ixgbe/ixgbe_ethdev.c
> +++ b/lib/librte_pmd_ixgbe/ixgbe_ethdev.c
> @@ -1054,8 +1054,8 @@ eth_ixgbevf_dev_init(struct rte_eth_dev *eth_dev)
>  			eth_dev->data->mac_addrs = NULL;
>  			return diag;
>  		}
> -		PMD_INIT_LOG(INFO, "\tVF MAC address not assigned by Host PF");
> -		PMD_INIT_LOG(INFO, "\tAssign randomly generated MAC address "
> +		PMD_INIT_LOG(NOTICE, "VF MAC address not assigned by Host PF");
> +		PMD_INIT_LOG(NOTICE, "Assign randomly generated MAC address "
>  			     "%02x:%02x:%02x:%02x:%02x:%02x",
>  			     perm_addr->addr_bytes[0],
>  			     perm_addr->addr_bytes[1],
> @@ -1248,7 +1248,7 @@ ixgbe_vlan_hw_strip_disable(struct rte_eth_dev *dev, uint16_t queue)
>  
>  	if (hw->mac.type == ixgbe_mac_82598EB) {
>  		/* No queue level support */
> -		PMD_INIT_LOG(INFO, "82598EB not support queue level hw strip");
> +		PMD_INIT_LOG(ERR, "82598EB not support queue level hw strip");

Should we not fix the text here to be "82599EB does not support ..." while we
are making this change? (Same with next chunk below too).

>  		return;
>  	}
>  	else {
> @@ -1272,7 +1272,7 @@ ixgbe_vlan_hw_strip_enable(struct rte_eth_dev *dev, uint16_t queue)
>  
>  	if (hw->mac.type == ixgbe_mac_82598EB) {
>  		/* No queue level supported */
> -		PMD_INIT_LOG(INFO, "82598EB not support queue level hw strip");
> +		PMD_INIT_LOG(ERR, "82598EB not support queue level hw strip");
>  		return;
>  	}
>  	else {
> @@ -2951,12 +2951,12 @@ ixgbevf_dev_configure(struct rte_eth_dev *dev)
>  	 */
>  #ifndef RTE_LIBRTE_IXGBE_PF_DISABLE_STRIP_CRC
>  	if (!conf->rxmode.hw_strip_crc) {
> -		PMD_INIT_LOG(INFO, "VF can't disable HW CRC Strip");
> +		PMD_INIT_LOG(NOTICE, "VF can't disable HW CRC Strip");
>  		conf->rxmode.hw_strip_crc = 1;
>  	}
>  #else
>  	if (conf->rxmode.hw_strip_crc) {
> -		PMD_INIT_LOG(INFO, "VF can't enable HW CRC Strip");
> +		PMD_INIT_LOG(NOTICE, "VF can't enable HW CRC Strip");
>  		conf->rxmode.hw_strip_crc = 0;
>  	}
>  #endif
> -- 
> 2.1.4
>