From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id A86CE9A9E for ; Mon, 18 May 2015 11:27:30 +0200 (CEST) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga102.fm.intel.com with ESMTP; 18 May 2015 02:27:29 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.13,452,1427785200"; d="scan'208";a="696475766" Received: from bricha3-mobl3.ger.corp.intel.com ([10.237.221.63]) by orsmga001.jf.intel.com with SMTP; 18 May 2015 02:27:27 -0700 Received: by (sSMTP sendmail emulation); Mon, 18 May 2015 10:27:26 +0025 Date: Mon, 18 May 2015 10:27:26 +0100 From: Bruce Richardson To: Stephen Hemminger Message-ID: <20150518092725.GB1636@bricha3-MOBL3> References: <1431709707-5281-1-git-send-email-stephen@networkplumber.org> <1431709707-5281-4-git-send-email-stephen@networkplumber.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1431709707-5281-4-git-send-email-stephen@networkplumber.org> Organization: Intel Shannon Ltd. User-Agent: Mutt/1.5.23 (2014-03-12) Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH 3/5] ixgbe: raise priority of significant events X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 May 2015 09:27:31 -0000 On Fri, May 15, 2015 at 10:08:25AM -0700, Stephen Hemminger wrote: > The driver does lots of logging at INFO level, but some setup > events are significant and should be at NOTICE or ERR level > since they are problems that user should see. > > Also never put tabs in log messages because they get mangled > by syslog processing. > > Signed-off-by: Stephen Hemminger Acked-by: Bruce Richardson One small nit below. > --- > lib/librte_pmd_ixgbe/ixgbe_ethdev.c | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/lib/librte_pmd_ixgbe/ixgbe_ethdev.c b/lib/librte_pmd_ixgbe/ixgbe_ethdev.c > index fa335f4..7e75382 100644 > --- a/lib/librte_pmd_ixgbe/ixgbe_ethdev.c > +++ b/lib/librte_pmd_ixgbe/ixgbe_ethdev.c > @@ -1054,8 +1054,8 @@ eth_ixgbevf_dev_init(struct rte_eth_dev *eth_dev) > eth_dev->data->mac_addrs = NULL; > return diag; > } > - PMD_INIT_LOG(INFO, "\tVF MAC address not assigned by Host PF"); > - PMD_INIT_LOG(INFO, "\tAssign randomly generated MAC address " > + PMD_INIT_LOG(NOTICE, "VF MAC address not assigned by Host PF"); > + PMD_INIT_LOG(NOTICE, "Assign randomly generated MAC address " > "%02x:%02x:%02x:%02x:%02x:%02x", > perm_addr->addr_bytes[0], > perm_addr->addr_bytes[1], > @@ -1248,7 +1248,7 @@ ixgbe_vlan_hw_strip_disable(struct rte_eth_dev *dev, uint16_t queue) > > if (hw->mac.type == ixgbe_mac_82598EB) { > /* No queue level support */ > - PMD_INIT_LOG(INFO, "82598EB not support queue level hw strip"); > + PMD_INIT_LOG(ERR, "82598EB not support queue level hw strip"); Should we not fix the text here to be "82599EB does not support ..." while we are making this change? (Same with next chunk below too). > return; > } > else { > @@ -1272,7 +1272,7 @@ ixgbe_vlan_hw_strip_enable(struct rte_eth_dev *dev, uint16_t queue) > > if (hw->mac.type == ixgbe_mac_82598EB) { > /* No queue level supported */ > - PMD_INIT_LOG(INFO, "82598EB not support queue level hw strip"); > + PMD_INIT_LOG(ERR, "82598EB not support queue level hw strip"); > return; > } > else { > @@ -2951,12 +2951,12 @@ ixgbevf_dev_configure(struct rte_eth_dev *dev) > */ > #ifndef RTE_LIBRTE_IXGBE_PF_DISABLE_STRIP_CRC > if (!conf->rxmode.hw_strip_crc) { > - PMD_INIT_LOG(INFO, "VF can't disable HW CRC Strip"); > + PMD_INIT_LOG(NOTICE, "VF can't disable HW CRC Strip"); > conf->rxmode.hw_strip_crc = 1; > } > #else > if (conf->rxmode.hw_strip_crc) { > - PMD_INIT_LOG(INFO, "VF can't enable HW CRC Strip"); > + PMD_INIT_LOG(NOTICE, "VF can't enable HW CRC Strip"); > conf->rxmode.hw_strip_crc = 0; > } > #endif > -- > 2.1.4 >