From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id F21719A9E for ; Mon, 18 May 2015 11:32:46 +0200 (CEST) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga101.jf.intel.com with ESMTP; 18 May 2015 02:32:41 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.13,452,1427785200"; d="scan'208";a="696477278" Received: from bricha3-mobl3.ger.corp.intel.com ([10.237.221.63]) by orsmga001.jf.intel.com with SMTP; 18 May 2015 02:32:40 -0700 Received: by (sSMTP sendmail emulation); Mon, 18 May 2015 10:32:39 +0025 Date: Mon, 18 May 2015 10:32:39 +0100 From: Bruce Richardson To: Stephen Hemminger Message-ID: <20150518093238.GE1636@bricha3-MOBL3> References: <1431709707-5281-1-git-send-email-stephen@networkplumber.org> <1431709707-5281-3-git-send-email-stephen@networkplumber.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1431709707-5281-3-git-send-email-stephen@networkplumber.org> Organization: Intel Shannon Ltd. User-Agent: Mutt/1.5.23 (2014-03-12) Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH 2/5] ixgbe: don't print PCI address on link change X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 May 2015 09:32:47 -0000 On Fri, May 15, 2015 at 10:08:24AM -0700, Stephen Hemminger wrote: > Printing PCI information on link state change is unnecessary since > the same information has already been displayed earlier in the log. > > Signed-off-by: Stephen Hemminger Acked-by: Bruce Richardson > --- > lib/librte_pmd_ixgbe/ixgbe_ethdev.c | 5 ----- > 1 file changed, 5 deletions(-) > > diff --git a/lib/librte_pmd_ixgbe/ixgbe_ethdev.c b/lib/librte_pmd_ixgbe/ixgbe_ethdev.c > index a585151..fa335f4 100644 > --- a/lib/librte_pmd_ixgbe/ixgbe_ethdev.c > +++ b/lib/librte_pmd_ixgbe/ixgbe_ethdev.c > @@ -2315,11 +2315,6 @@ ixgbe_dev_link_status_print(struct rte_eth_dev *dev) > PMD_INIT_LOG(INFO, "Port %u: Link Down", > dev->data->port_id); > } > - PMD_INIT_LOG(INFO, "PCI Address: %04d:%02d:%02d:%d", > - dev->pci_dev->addr.domain, > - dev->pci_dev->addr.bus, > - dev->pci_dev->addr.devid, > - dev->pci_dev->addr.function); > } > > /* > -- > 2.1.4 >