From: Bruce Richardson <bruce.richardson@intel.com>
To: Helin Zhang <helin.zhang@intel.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v2 1/2] i40e/base: compile fix on ICC 13.0.0
Date: Mon, 18 May 2015 16:13:46 +0100 [thread overview]
Message-ID: <20150518151345.GC12164@bricha3-MOBL3> (raw)
In-Reply-To: <20150518151106.GA12164@bricha3-MOBL3>
On Mon, May 18, 2015 at 04:11:06PM +0100, Bruce Richardson wrote:
> On Mon, May 18, 2015 at 11:03:28PM +0800, Helin Zhang wrote:
> > Below compile error can be found on ICC 13.0.0, which is a warning
> > treated as error. Forcedly disabling the warning can fix it.
> >
> > Error log:
> > lib/librte_pmd_i40e/i40e/i40e_nvm.c(1022): error #188: enumerated
> > type mixed with another type
> > hw->aq.asq_last_status = old_asq_status;
> > ^
> >
> > Signed-off-by: Helin Zhang <helin.zhang@intel.com>
>
> Acked-by: Bruce Richardson <bruce.richardson@intel.com>
>
Fix works, but you probably should reword the title to start with "fix".
For future reference, it would also be nice to reference the commit that broke things.
> > ---
> > lib/librte_pmd_i40e/Makefile | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/lib/librte_pmd_i40e/Makefile b/lib/librte_pmd_i40e/Makefile
> > index 22f0716..911e4f5 100644
> > --- a/lib/librte_pmd_i40e/Makefile
> > +++ b/lib/librte_pmd_i40e/Makefile
> > @@ -48,7 +48,7 @@ LIBABIVER := 1
> > # to disable warnings
> > #
> > ifeq ($(CC), icc)
> > -CFLAGS_BASE_DRIVER = -wd593
> > +CFLAGS_BASE_DRIVER = -wd593 -wd188
> > else ifeq ($(CC), clang)
> > CFLAGS_BASE_DRIVER += -Wno-sign-compare
> > CFLAGS_BASE_DRIVER += -Wno-unused-value
> > --
> > 1.8.1.4
> >
next prev parent reply other threads:[~2015-05-18 15:14 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-18 13:52 [dpdk-dev] [PATCH] i40e: " Helin Zhang
2015-05-18 15:03 ` [dpdk-dev] [PATCH v2 0/2] compile fixes on ICC and clang Helin Zhang
2015-05-18 15:03 ` [dpdk-dev] [PATCH v2 1/2] i40e/base: compile fix on ICC 13.0.0 Helin Zhang
2015-05-18 15:11 ` Bruce Richardson
2015-05-18 15:13 ` Bruce Richardson [this message]
2015-05-18 15:03 ` [dpdk-dev] [PATCH v2 2/2] i40e/base: compile fix on clang 3.3 Helin Zhang
2015-05-18 15:11 ` Bruce Richardson
2015-05-18 15:40 ` [dpdk-dev] [PATCH v3 0/2] fix compile with ICC and clang Helin Zhang
2015-05-18 15:40 ` [dpdk-dev] [PATCH v3 1/2] i40e/base: fix compile with ICC 13.0.0 Helin Zhang
2015-05-18 15:40 ` [dpdk-dev] [PATCH v3 2/2] i40e/base: fix compile with clang 3.3 Helin Zhang
2015-05-18 15:43 ` [dpdk-dev] [PATCH v3 0/2] fix compile with ICC and clang Bruce Richardson
2015-05-19 10:32 ` Thomas Monjalon
2015-05-19 14:12 ` Zhang, Helin
2015-05-19 1:25 ` [dpdk-dev] [PATCH v2 0/2] compile fixes on " Tetsuya Mukawa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150518151345.GC12164@bricha3-MOBL3 \
--to=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=helin.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).