From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <bruce.richardson@intel.com>
Received: from mga03.intel.com (mga03.intel.com [134.134.136.65])
 by dpdk.org (Postfix) with ESMTP id 3F243C324
 for <dev@dpdk.org>; Mon, 18 May 2015 17:14:03 +0200 (CEST)
Received: from fmsmga002.fm.intel.com ([10.253.24.26])
 by orsmga103.jf.intel.com with ESMTP; 18 May 2015 08:13:49 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.13,453,1427785200"; d="scan'208";a="727807777"
Received: from bricha3-mobl3.ger.corp.intel.com ([10.237.221.63])
 by fmsmga002.fm.intel.com with SMTP; 18 May 2015 08:13:46 -0700
Received: by  (sSMTP sendmail emulation); Mon, 18 May 2015 16:13:46 +0025
Date: Mon, 18 May 2015 16:13:46 +0100
From: Bruce Richardson <bruce.richardson@intel.com>
To: Helin Zhang <helin.zhang@intel.com>
Message-ID: <20150518151345.GC12164@bricha3-MOBL3>
References: <1431957127-21395-1-git-send-email-helin.zhang@intel.com>
 <1431961409-22252-1-git-send-email-helin.zhang@intel.com>
 <1431961409-22252-2-git-send-email-helin.zhang@intel.com>
 <20150518151106.GA12164@bricha3-MOBL3>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20150518151106.GA12164@bricha3-MOBL3>
Organization: Intel Shannon Ltd.
User-Agent: Mutt/1.5.23 (2014-03-12)
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v2 1/2] i40e/base: compile fix on ICC 13.0.0
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 18 May 2015 15:14:03 -0000

On Mon, May 18, 2015 at 04:11:06PM +0100, Bruce Richardson wrote:
> On Mon, May 18, 2015 at 11:03:28PM +0800, Helin Zhang wrote:
> > Below compile error can be found on ICC 13.0.0, which is a warning
> > treated as error. Forcedly disabling the warning can fix it.
> > 
> > Error log:
> > lib/librte_pmd_i40e/i40e/i40e_nvm.c(1022): error #188: enumerated
> > type mixed with another type
> > hw->aq.asq_last_status = old_asq_status;
> >                        ^
> > 
> > Signed-off-by: Helin Zhang <helin.zhang@intel.com>
> 
> Acked-by: Bruce Richardson <bruce.richardson@intel.com>
> 

Fix works, but you probably should reword the title to start with "fix".

For future reference, it would also be nice to reference the commit that broke things.


> > ---
> >  lib/librte_pmd_i40e/Makefile | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/lib/librte_pmd_i40e/Makefile b/lib/librte_pmd_i40e/Makefile
> > index 22f0716..911e4f5 100644
> > --- a/lib/librte_pmd_i40e/Makefile
> > +++ b/lib/librte_pmd_i40e/Makefile
> > @@ -48,7 +48,7 @@ LIBABIVER := 1
> >  # to disable warnings
> >  #
> >  ifeq ($(CC), icc)
> > -CFLAGS_BASE_DRIVER = -wd593
> > +CFLAGS_BASE_DRIVER = -wd593 -wd188
> >  else ifeq ($(CC), clang)
> >  CFLAGS_BASE_DRIVER += -Wno-sign-compare
> >  CFLAGS_BASE_DRIVER += -Wno-unused-value
> > -- 
> > 1.8.1.4
> >