From: Bruce Richardson <bruce.richardson@intel.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: dev@dpdk.org, Stephen Hemminger <shemming@brocade.com>
Subject: Re: [dpdk-dev] [PATCH 1/2] enic: silence log message
Date: Tue, 19 May 2015 11:08:53 +0100 [thread overview]
Message-ID: <20150519100853.GB11036@bricha3-MOBL3> (raw)
In-Reply-To: <1428514670-7982-2-git-send-email-stephen@networkplumber.org>
On Wed, Apr 08, 2015 at 10:37:49AM -0700, Stephen Hemminger wrote:
> From: Stephen Hemminger <shemming@brocade.com>
>
> Silence is normal. drivers should speak only when spoken to and not
> be chatty.
>
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
Acked-by: Bruce Richardson <bruce.richardson@intel.com>
> ---
> lib/librte_pmd_enic/enic_main.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/lib/librte_pmd_enic/enic_main.c b/lib/librte_pmd_enic/enic_main.c
> index 0892b3e..508621e 100644
> --- a/lib/librte_pmd_enic/enic_main.c
> +++ b/lib/librte_pmd_enic/enic_main.c
> @@ -1048,8 +1048,6 @@ int enic_probe(struct enic *enic)
> struct rte_pci_device *pdev = enic->pdev;
> int err = -1;
>
> - dev_debug(enic, " Initializing ENIC PMD version %s\n", DRV_VERSION);
> -
> enic->bar0.vaddr = (void *)pdev->mem_resource[0].addr;
> enic->bar0.len = pdev->mem_resource[0].len;
>
> --
> 2.1.4
>
next prev parent reply other threads:[~2015-05-19 10:08 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-08 17:37 [dpdk-dev] [PATCH 0/2] small changes Stephen Hemminger
2015-04-08 17:37 ` [dpdk-dev] [PATCH 1/2] enic: silence log message Stephen Hemminger
2015-05-19 10:08 ` Bruce Richardson [this message]
2015-05-20 16:30 ` Sujith Sankar (ssujith)
2015-05-20 17:47 ` Stephen Hemminger
2015-05-21 1:52 ` Sujith Sankar (ssujith)
2015-07-30 17:03 ` [dpdk-dev] [PATCH v2] enic: silence log message unless debug enabled Stephen Hemminger
2015-07-30 19:18 ` Thomas Monjalon
2015-04-08 17:37 ` [dpdk-dev] [PATCH 2/2] tools: fix comment in bind script Stephen Hemminger
2015-04-15 9:43 ` Bruce Richardson
2015-08-03 16:38 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150519100853.GB11036@bricha3-MOBL3 \
--to=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=shemming@brocade.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).