From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <rahul.lakkireddy@chelsio.com>
Received: from stargate3.asicdesigners.com (stargate.chelsio.com
 [67.207.112.58]) by dpdk.org (Postfix) with ESMTP id B9C365949
 for <dev@dpdk.org>; Sat, 23 May 2015 07:58:22 +0200 (CEST)
Received: from localhost (scalar.blr.asicdesigners.com [10.193.185.94])
 by stargate3.asicdesigners.com (8.13.8/8.13.8) with ESMTP id t4N5wIkS014123;
 Fri, 22 May 2015 22:58:19 -0700
Date: Sat, 23 May 2015 11:27:56 +0530
From: Rahul Lakkireddy <rahul.lakkireddy@chelsio.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Message-ID: <20150523055755.GC4569@scalar.blr.asicdesigners.com>
References: <cover.1432300701.git.rahul.lakkireddy@chelsio.com>
 <25f06823ef87d05bf57d996df387478e7fbc966f.1432300701.git.rahul.lakkireddy@chelsio.com>
 <20150522094250.503af8af@urahara>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20150522094250.503af8af@urahara>
User-Agent: Mutt/1.5.21 (2010-09-15)
Cc: dev@dpdk.org, Felix Marti <felix@chelsio.com>,
 Kumar Sanghvi <kumaras@chelsio.com>,
 Nirranjan Kirubaharan <nirranjan@chelsio.com>
Subject: Re: [dpdk-dev] [PATCH 2/5] cxgbe: add cxgbe poll mode driver.
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Sat, 23 May 2015 05:58:23 -0000

On Fri, May 22, 2015 at 09:42:50 -0700, Stephen Hemminger wrote:
> On Fri, 22 May 2015 18:54:20 +0530
> Rahul Lakkireddy <rahul.lakkireddy@chelsio.com> wrote:
> 
> > +#define pr_err(y, args...) dev_err(0, y, ##args)
> > +#define pr_warn(y, args...) dev_warn(0, y, ##args)
> > +#define pr_info(y, args...) dev_info(0, y, ##args)
> > +#define BUG() pr_err("BUG at %s:%d", __func__, __LINE__)
> > +
> > +#define ASSERT(x) do {\
> > +	if (!(x)) \
> > +		rte_panic("CXGBE: x"); \
> > +} while (0)
> > +#define BUG_ON(x) ASSERT(!(x))
> > +
> > +#ifndef WARN_ON
> > +#define WARN_ON(x) do { \
> > +	int ret = !!(x); \
> > +	if (unlikely(ret)) \
> > +		pr_warn("WARN_ON: \"" #x "\" at %s:%d\n", __func__, __LINE__); \
> > +} while (0)
> > +#endif
> > +
> > +#define __iomem
> > +
> > +#ifndef BIT
> > +#define BIT(n) (1 << (n))
> > +#endif
> > +
> > +#define L1_CACHE_SHIFT  6
> > +#define L1_CACHE_BYTES  BIT(L1_CACHE_SHIFT)
> > +
> > +#define PAGE_SHIFT  12
> > +#define ALIGN(x, a) (((x) + (a) - 1) & ~((a) - 1))
> > +#define PTR_ALIGN(p, a) ((typeof(p))ALIGN((unsigned long)(p), (a)))
> > +
> > +#define VLAN_HLEN 4
> > +
> > +#define rmb()     rte_rmb() /* dpdk rte provided rmb */
> > +#define wmb()     rte_wmb() /* dpdk rte provided wmb */
> > +
> > +typedef uint8_t   u8;
> > +typedef int8_t    s8;
> > +typedef uint16_t  u16;
> > +typedef uint32_t  u32;
> > +typedef int32_t   s32;
> > +typedef uint64_t  u64;
> > +typedef int       bool;
> > +typedef uint64_t  dma_addr_t;
> > +
> > +#ifndef __le16
> > +#define __le16	uint16_t
> > +#endif
> > +#ifndef __le32
> > +#define __le32	uint32_t
> > +#endif
> > +#ifndef __le64
> > +#define __le64	uint64_t
> > +#endif
> > +#ifndef __be16
> > +#define __be16	uint16_t
> > +#endif
> > +#ifndef __be32
> > +#define __be32	uint32_t
> > +#endif
> > +#ifndef __be64
> > +#define __be64	uint64_t
> > +#endif
> > +#ifndef __u8
> > +#define __u8	uint8_t
> > +#endif
> > +#ifndef __u16
> > +#define __u16	uint16_t
> > +#endif
> > +#ifndef __u32
> > +#define __u32	uint32_t
> > +#endif
> > +#ifndef __u64
> > +#define __u64	uint64_t
> > +#endif
> > +
> > +#define FALSE	0
> > +#define TRUE	1
> > +#define false	0
> > +#define true	1
> > +
> > +#define min(a, b) RTE_MIN(a, b)
> > +#define max(a, b) RTE_MAX(a, b)
> 
> This is not Linux kernel.
> Please don't create wrappers for all the stuff in Linux to port your driver.

We actually referred several PMD's compat file including - enic_compat.h,
i40e_osdep.h, ixgbe_osdep.h, fm10k_osdep.h, etc.

Most of the types above are already defined by many of existing PMD's compat
file.  Can we at-least keep those which are already defined by several PMD's
compat file?


Thanks,
Rahul.