From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <stephen@networkplumber.org>
Received: from mail-pa0-f43.google.com (mail-pa0-f43.google.com
 [209.85.220.43]) by dpdk.org (Postfix) with ESMTP id 38133C2FC
 for <dev@dpdk.org>; Mon, 25 May 2015 19:42:30 +0200 (CEST)
Received: by pacwv17 with SMTP id wv17so74730230pac.2
 for <dev@dpdk.org>; Mon, 25 May 2015 10:42:29 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to
 :references:mime-version:content-type:content-transfer-encoding;
 bh=NrvuZDdV/iEeScy7AAjQn7w1xUg+2rnCfq2hrFoP+oE=;
 b=NSSu+hWUMcCaekoosry1GU7Ib+2E9DIX4b8GEFWZhZKm0i7yHNGLycqfVQ94BQ74lQ
 DSyF6MCst5NU71KpEFhJLVw9Uu8zP2CCxpMFKyYoH27MytIbabUFKkNeXNt3ke/rA4kk
 bBmmC9Kr5z6npjNx58BLZSQSL1002e9za6MPdo7004iTMcZa6RPTassHQG+91N4hP9R3
 r6T5kHya/57axPBBZjPdODXXApfMBbDM+7coYs98BnwOZAPRUA1pTY97jC/IOj0H3Ong
 gB5aWbiO7lp9M9IcFyUhx5hVVHN/AWLA1Mq8//nfT5coosOdqAgAn+yuLu+CS8183Id4
 ztTg==
X-Gm-Message-State: ALoCoQmGzZdFY3l8N1AMuiMEi4BH+xZLpgNqXBpaAYd1OTzzUYictAOpmzhww2x354oo4o71grzD
X-Received: by 10.70.103.132 with SMTP id fw4mr40872186pdb.5.1432575749574;
 Mon, 25 May 2015 10:42:29 -0700 (PDT)
Received: from urahara (static-50-53-82-155.bvtn.or.frontiernet.net.
 [50.53.82.155])
 by mx.google.com with ESMTPSA id c16sm10643000pdl.61.2015.05.25.10.42.29
 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Mon, 25 May 2015 10:42:29 -0700 (PDT)
Date: Mon, 25 May 2015 10:42:33 -0700
From: Stephen Hemminger <stephen@networkplumber.org>
To: "Liang, Cunming" <cunming.liang@intel.com>
Message-ID: <20150525104233.532583c6@urahara>
In-Reply-To: <5562E37B.7090605@intel.com>
References: <1431970814-25951-1-git-send-email-stephen@networkplumber.org>
 <1431970814-25951-6-git-send-email-stephen@networkplumber.org>
 <5562E37B.7090605@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: dev@dpdk.org, cumming.lian@intel.com
Subject: Re: [dpdk-dev] [PATCH 5/5] uio: integrate MSI-X support
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 25 May 2015 17:42:30 -0000

On Mon, 25 May 2015 16:55:23 +0800
"Liang, Cunming" <cunming.liang@intel.com> wrote:

> > +			irqs.fd = intr_handle->fd;
> > +
> > +		if (ioctl(intr_handle->vfio_dev_fd, UIO_MSI_IRQ_SET, &irqs) < 0) {  
> It would be strange if using vfio_dev_fd in 'uio_msix_' related function.

Just minor variable name. The whole set of fd's etc, probably need better names..