From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pa0-f45.google.com (mail-pa0-f45.google.com [209.85.220.45]) by dpdk.org (Postfix) with ESMTP id E70E7ADA2 for ; Tue, 26 May 2015 23:57:29 +0200 (CEST) Received: by pabru16 with SMTP id ru16so102387897pab.1 for ; Tue, 26 May 2015 14:57:29 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-type:content-transfer-encoding; bh=HlBWoMZMdEAHe2DvZdX76xqJvta05JcxspqgZhSaMk4=; b=BYXOjTIbKvQoa/pVgykdNBAG+mzeVFr+9LdlIg6jn19X+fXU+0YuszJlI7+zJZ3IUN W5i7xC0Uoi6V3vRqjxkoIlHL6NX5w7mC4ryjd1JOnnRNz7VrAwgfC3MwRvJJLrW136/C 6WZ/pzkBWlUbytBFULZ+QWngJOBw7q5AkVsnkrXrMfr0rMvV3T8uG7KpebJucoSpEpMY EYRphlWNXHa5AYFXd8rdJiu+K/FfiWw6/jZvBK4L1XU4Dh9HeU/wEjVLYNVquFdsOBe2 Sg8x3RUcrsU/JGIz2xsMHdat/oCq+rENCP+OuNyR9RlJF6ZyxiOCt72F+/rXDPOMkJwX X6sA== X-Gm-Message-State: ALoCoQk1VM8UtuxHbam9n/7ILDkPXdo98ZYz13UYJyjDHck0d0j1vmGMMW6LEF8NRSnoWCVRhYIP X-Received: by 10.68.197.161 with SMTP id iv1mr53256792pbc.0.1432677449305; Tue, 26 May 2015 14:57:29 -0700 (PDT) Received: from urahara (static-50-53-82-155.bvtn.or.frontiernet.net. [50.53.82.155]) by mx.google.com with ESMTPSA id u8sm14045406pdj.46.2015.05.26.14.57.28 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 26 May 2015 14:57:29 -0700 (PDT) Date: Tue, 26 May 2015 14:57:32 -0700 From: Stephen Hemminger To: "Dumitrescu, Cristian" Message-ID: <20150526145732.022b5a41@urahara> In-Reply-To: <3EB4FA525960D640B5BDFFD6A3D891263236CA8C@IRSMSX108.ger.corp.intel.com> References: <1432643987-8916-1-git-send-email-maciejx.t.gajdzica@intel.com> <1432643987-8916-2-git-send-email-maciejx.t.gajdzica@intel.com> <20150526075754.791473f6@urahara> <3EB4FA525960D640B5BDFFD6A3D891263236CA8C@IRSMSX108.ger.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH v3 01/10] table: added structure for storing table stats X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 26 May 2015 21:57:30 -0000 On Tue, 26 May 2015 21:40:42 +0000 "Dumitrescu, Cristian" wrote: > > > > -----Original Message----- > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Stephen > > Hemminger > > Sent: Tuesday, May 26, 2015 3:58 PM > > To: Gajdzica, MaciejX T > > Cc: dev@dpdk.org > > Subject: Re: [dpdk-dev] [PATCH v3 01/10] table: added structure for storing > > table stats > > > > On Tue, 26 May 2015 14:39:38 +0200 > > Maciej Gajdzica wrote: > > > > > + > > > /** Lookup table interface defining the lookup table operation */ > > > struct rte_table_ops { > > > rte_table_op_create f_create; /**< Create */ > > > @@ -194,6 +218,7 @@ struct rte_table_ops { > > > rte_table_op_entry_add f_add; /**< Entry add */ > > > rte_table_op_entry_delete f_delete; /**< Entry delete */ > > > rte_table_op_lookup f_lookup; /**< Lookup */ > > > + rte_table_op_stats_read f_stats; /**< Stats */ > > > }; > > > > Another good idea, which is an ABI change. > > This is simply adding a new API function, this is not changing any function prototype. There is no change required in the map file of this library. Is there anything we should have done and we did not do? > But if I built an external set of code which had rte_table_ops (don't worry I haven't) and that binary ran with the new definition, the core code it table would reference outside the (old version) of rte_table_ops structure and find garbage.