From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from stargate3.asicdesigners.com (stargate.chelsio.com [67.207.112.58]) by dpdk.org (Postfix) with ESMTP id C47BE3237 for ; Tue, 26 May 2015 20:13:30 +0200 (CEST) Received: from localhost (scalar.blr.asicdesigners.com [10.193.185.94]) by stargate3.asicdesigners.com (8.13.8/8.13.8) with ESMTP id t4QIDQHA008577; Tue, 26 May 2015 11:13:27 -0700 Date: Tue, 26 May 2015 23:43:01 +0530 From: Rahul Lakkireddy To: Stephen Hemminger Message-ID: <20150526181259.GA8700@scalar.blr.asicdesigners.com> References: <25f06823ef87d05bf57d996df387478e7fbc966f.1432300701.git.rahul.lakkireddy@chelsio.com> <20150522094250.503af8af@urahara> <20150523055755.GC4569@scalar.blr.asicdesigners.com> <20150526170206.GA8187@scalar.blr.asicdesigners.com> <20150526102437.555dc199@urahara> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150526102437.555dc199@urahara> User-Agent: Mutt/1.5.21 (2010-09-15) Cc: dev@dpdk.org, Felix Marti , Nirranjan Kirubaharan , Kumar Sanghvi Subject: Re: [dpdk-dev] [PATCH 2/5] cxgbe: add cxgbe poll mode driver. X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 26 May 2015 18:13:31 -0000 On Tue, May 26, 2015 at 10:24:37 -0700, Stephen Hemminger wrote: > On Tue, 26 May 2015 22:32:07 +0530 > Rahul Lakkireddy wrote: > > > On Sat, May 23, 2015 at 11:27:56 +0530, Rahul Lakkireddy wrote: > > > On Fri, May 22, 2015 at 09:42:50 -0700, Stephen Hemminger wrote: > > > > On Fri, 22 May 2015 18:54:20 +0530 > > > > Rahul Lakkireddy wrote: > > > > [...] > > > > > > > > This is not Linux kernel. > > > > Please don't create wrappers for all the stuff in Linux to port your driver. > > > > > > We actually referred several PMD's compat file including - enic_compat.h, > > > i40e_osdep.h, ixgbe_osdep.h, fm10k_osdep.h, etc. > > > > > > Most of the types above are already defined by many of existing PMD's compat > > > file. Can we at-least keep those which are already defined by several PMD's > > > compat file? > > > > Just to give a background - since we are new to dpdk community, we studied the > > already merged PMD's compat files as reference to understand how things are > > done for driver submission. And so, we wrote cxgbe compat file along similar > > lines. However, if above wrappers are not acceptable then, we will definitely > > remove them in V2. > > > > Just trying to get a clarification so that we don't repeat the same mistake in > > V2 submission. Reviews from you and dpdk community are more than welcome and > > appreciated. > > Does this driver share source code with other platforms? Yes. The h/w specific code is common to Linux and FBSD. And we will be enabling FBSD support soon after this PMD gets merged and we are able to carry out and complete testing on FBSD. > If it does then the compatibility wrappers make sense and reduce the > maintenance effort. > If the driver is a standalone port to DPDK, then it makes sense to complete > the effort and use standard DPDK coding practices (stdint, stdbool, etc). > > The other drivers in DPDK do things based on that. Many of the hardware > drivers share code with BSD. Others like the virtual drivers were written > or ported completely from scratch. > Thank you for your guidance.