From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <rahul.lakkireddy@chelsio.com>
Received: from stargate3.asicdesigners.com (stargate.chelsio.com
 [67.207.112.58]) by dpdk.org (Postfix) with ESMTP id DD11D567E
 for <dev@dpdk.org>; Wed, 27 May 2015 13:25:20 +0200 (CEST)
Received: from localhost (scalar.blr.asicdesigners.com [10.193.185.94])
 by stargate3.asicdesigners.com (8.13.8/8.13.8) with ESMTP id t4RBPFeQ015426;
 Wed, 27 May 2015 04:25:16 -0700
Date: Wed, 27 May 2015 16:54:49 +0530
From: Rahul Lakkireddy <rahul.lakkireddy@chelsio.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Message-ID: <20150527112447.GA29377@scalar.blr.asicdesigners.com>
References: <cover.1432300701.git.rahul.lakkireddy@chelsio.com>
 <3cfa0501a13852cd9cc131a5d2028da34f100fd5.1432300701.git.rahul.lakkireddy@chelsio.com>
 <1895664.ZyjcRCpONx@xps13>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1895664.ZyjcRCpONx@xps13>
User-Agent: Mutt/1.5.21 (2010-09-15)
Cc: dev@dpdk.org, Felix Marti <felix@chelsio.com>,
 Kumar Sanghvi <kumaras@chelsio.com>,
 Nirranjan Kirubaharan <nirranjan@chelsio.com>
Subject: Re: [dpdk-dev] [PATCH 3/5] doc: add cxgbe PMD documentation under
 doc/guides/nics/cxgbe.rst
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 27 May 2015 11:25:21 -0000

On Wed, May 27, 2015 at 07:38:50 +0200, Thomas Monjalon wrote:
> 2015-05-22 18:54, Rahul Lakkireddy:
> > Adds cxgbe poll mode driver documentation under the usual doc/guides/nics/
> > directory with the rest of the drivers.  The documentation covers cxgbe
> > implementation details, features and limitations, prerequisites, configuration,
> > and a sample application usage.
> > 
> > Signed-off-by: Rahul Lakkireddy <rahul.lakkireddy@chelsio.com>
> > Signed-off-by: Kumar Sanghvi <kumaras@chelsio.com>
> 
> Nice documentation, thank you.
> Do not hesitate to add some design insights which would help tuning or
> maintenance.

Sure. I will figure out if something can be added to documentation for tuning
part.

> 
> > --- a/doc/guides/nics/index.rst
> > +++ b/doc/guides/nics/index.rst
> > @@ -44,6 +44,7 @@ Network Interface Controller Drivers
> >      ixgbe
> >      intel_vf
> >      mlx4
> > +    cxgbe
> >      virtio
> >      vmxnet3
> 
> Please add it in the alphabetical order.

Ok. Will correct this in v2.

Thanks,
Rahul.