From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id D64915957 for ; Wed, 27 May 2015 15:55:36 +0200 (CEST) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga102.jf.intel.com with ESMTP; 27 May 2015 06:55:35 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.13,505,1427785200"; d="scan'208";a="701003115" Received: from bricha3-mobl3.ger.corp.intel.com ([10.237.220.149]) by orsmga001.jf.intel.com with SMTP; 27 May 2015 06:55:34 -0700 Received: by (sSMTP sendmail emulation); Wed, 27 May 2015 14:55:33 +0025 Date: Wed, 27 May 2015 14:55:33 +0100 From: Bruce Richardson To: Marc Sune Message-ID: <20150527135533.GB10480@bricha3-MOBL3> References: <1432734469-1668-1-git-send-email-bruce.richardson@intel.com> <5565CC22.8050003@bisdn.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5565CC22.8050003@bisdn.de> Organization: Intel Shannon Ltd. User-Agent: Mutt/1.5.23 (2014-03-12) Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH 1/4] kni: add function to query the name of a kni object X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 27 May 2015 13:55:37 -0000 On Wed, May 27, 2015 at 03:52:34PM +0200, Marc Sune wrote: > > > On 27/05/15 15:47, Bruce Richardson wrote: > >When a KNI object is created, a name is assigned to it which is stored > >internally. There is also an API function to look up a KNI object by > >name, but there is no API to query the current name of an existing > >KNI object. This patch adds just such an API. > > > >Signed-off-by: Bruce Richardson > >--- > > lib/librte_kni/rte_kni.c | 6 ++++++ > > lib/librte_kni/rte_kni.h | 10 ++++++++++ > > lib/librte_kni/rte_kni_version.map | 1 + > > 3 files changed, 17 insertions(+) > > > >diff --git a/lib/librte_kni/rte_kni.c b/lib/librte_kni/rte_kni.c > >index 4e70fa0..c5a0089 100644 > >--- a/lib/librte_kni/rte_kni.c > >+++ b/lib/librte_kni/rte_kni.c > >@@ -674,6 +674,12 @@ rte_kni_get(const char *name) > > return NULL; > > } > >+const char * > >+rte_kni_get_name(const struct rte_kni *kni) > >+{ > >+ return kni->name; > >+} > > Since a pointer to the kni context (struct rte_kni) is exposed to the user > (rte_kni_get() and rte_kni_alloc ()), and the field is directly in the > struct, is this API call really necessary? I would only see this necessary > if the API would only expose a handle, like a port_id for ethdev > > Marc The structure definition is in rte_kni.c, not in the header file, so applications can't read the name directly. In other words, the create API just exposes a handle. [The structure in the header is the conf structure, not the full kni struct] /Bruce > > >+ > > /* > > * It is deprecated and just for backward compatibility. > > */ > >diff --git a/lib/librte_kni/rte_kni.h b/lib/librte_kni/rte_kni.h > >index 44240fe..0c74251 100644 > >--- a/lib/librte_kni/rte_kni.h > >+++ b/lib/librte_kni/rte_kni.h > >@@ -248,6 +248,16 @@ extern uint8_t rte_kni_get_port_id(struct rte_kni *kni) \ > > extern struct rte_kni *rte_kni_get(const char *name); > > /** > >+ * Get the name given to a KNI device > >+ * > >+ * @param kni > >+ * The KNI instance to query > >+ * @return > >+ * The pointer to the KNI name > >+ */ > >+extern const char *rte_kni_get_name(const struct rte_kni *kni); > >+ > >+/** > > * Get the KNI context of the specific port. > > * > > * Note: It is deprecated and just for backward compatibility. > >diff --git a/lib/librte_kni/rte_kni_version.map b/lib/librte_kni/rte_kni_version.map > >index b0bbf4d..e5e4e1b 100644 > >--- a/lib/librte_kni/rte_kni_version.map > >+++ b/lib/librte_kni/rte_kni_version.map > >@@ -6,6 +6,7 @@ DPDK_2.0 { > > rte_kni_create; > > rte_kni_get; > > rte_kni_get_port_id; > >+ rte_kni_get_name; > > rte_kni_handle_request; > > rte_kni_info_get; > > rte_kni_init; >