From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-000f0801.pphosted.com (mx0a-000f0801.pphosted.com [67.231.144.122]) by dpdk.org (Postfix) with ESMTP id 183C05A57 for ; Fri, 29 May 2015 17:28:40 +0200 (CEST) Received: from pps.filterd (m0048193.ppops.net [127.0.0.1]) by mx0a-000f0801.pphosted.com (8.14.7/8.14.7) with SMTP id t4TFH0ob015722 for ; Fri, 29 May 2015 08:28:39 -0700 Received: from hq1wp-exchub01.corp.brocade.com ([144.49.131.13]) by mx0a-000f0801.pphosted.com with ESMTP id 1up6gk293n-1 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NOT) for ; Fri, 29 May 2015 08:28:39 -0700 Received: from BRMWP-EXCHUB02.corp.brocade.com (172.16.187.99) by HQ1WP-EXCHUB01.corp.brocade.com (10.70.36.101) with Microsoft SMTP Server (TLS) id 14.3.123.3; Fri, 29 May 2015 08:28:04 -0700 Received: from BRMWP-EXMB11.corp.brocade.com (172.16.59.77) by BRMWP-EXCHUB02.corp.brocade.com (172.16.187.99) with Microsoft SMTP Server (TLS) id 14.3.123.3; Fri, 29 May 2015 09:27:21 -0600 Received: from urahara (10.72.40.78) by BRMWP-EXMB11.corp.brocade.com (172.16.59.77) with Microsoft SMTP Server (TLS) id 15.0.1044.25; Fri, 29 May 2015 09:27:20 -0600 Date: Fri, 29 May 2015 08:27:22 -0700 From: Stephen Hemminger To: Message-ID: <20150529082722.26b22923@urahara> In-Reply-To: <1432889125-20255-13-git-send-email-cunming.liang@intel.com> References: <1432198563-16334-1-git-send-email-cunming.liang@intel.com> <1432889125-20255-1-git-send-email-cunming.liang@intel.com> <1432889125-20255-13-git-send-email-cunming.liang@intel.com> Organization: Brocade MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-ClientProxiedBy: hq1wp-excas12.corp.brocade.com (10.70.38.22) To BRMWP-EXMB11.corp.brocade.com (172.16.59.77) X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:5.14.151, 1.0.33, 0.0.0000 definitions=2015-05-29_05:2015-05-29,2015-05-29,1970-01-01 signatures=0 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 suspectscore=3 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=7.0.1-1402240000 definitions=main-1505290190 X-Mailman-Approved-At: Mon, 01 Jun 2015 10:24:03 +0200 Subject: Re: [dpdk-dev] [PATCH v9 12/12] abi: fix v2.1 abi broken issue X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 29 May 2015 15:28:41 -0000 On Fri, 29 May 2015 16:45:25 +0800 Cunming Liang wrote: > +#ifdef RTE_EAL_RX_INTR > +extern int > rte_eth_dev_rx_intr_ctl(uint8_t port_id, int epfd, int op, void *data); > +#else > +static inline int > +rte_eth_dev_rx_intr_ctl(uint8_t port_id, int epfd, int op, void *data) > +{ > + RTE_SET_USED(port_id); > + RTE_SET_USED(epfd); > + RTE_SET_USED(op); > + RTE_SET_USED(data); > + return -1; > +} > +#endif Doing ABI compatibility is good but hard. I think it would be better not to provide the functions for rx_intr_ctl unless the feature was configured on. That way anyone using them with incorrect config would detect failure at build time, rather than run time. Also, doesn't some doc file have to be updated for the announcement?