From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.tuxdriver.com (charlotte.tuxdriver.com [70.61.120.58]) by dpdk.org (Postfix) with ESMTP id 4D2255A87 for ; Fri, 29 May 2015 18:58:08 +0200 (CEST) Received: from hmsreliant.think-freely.org ([2001:470:8:a08:7aac:c0ff:fec2:933b] helo=localhost) by smtp.tuxdriver.com with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.63) (envelope-from ) id 1YyNbd-0008SB-Kc; Fri, 29 May 2015 12:58:06 -0400 Date: Fri, 29 May 2015 12:57:55 -0400 From: Neil Horman To: Bruce Richardson Message-ID: <20150529165755.GD29575@hmsreliant.think-freely.org> References: <1432904027-6578-1-git-send-email-bruce.richardson@intel.com> <1432910056-6946-1-git-send-email-bruce.richardson@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1432910056-6946-1-git-send-email-bruce.richardson@intel.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-Spam-Score: -2.9 (--) X-Spam-Status: No Cc: dev@dpdk.org, neil.horman@tuxdriver.com Subject: Re: [dpdk-dev] [PATCH v2 0/4] fix compilation on Fedora 22 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 29 May 2015 16:58:08 -0000 On Fri, May 29, 2015 at 03:34:12PM +0100, Bruce Richardson wrote: > V2 Changes: > * use RTE_MIN instead of additional comparison checks > in some loops, as suggested by Neil. > * For stats reset in null PMD, just use the size of the > array [which is 1] in place of the used queue counts. > > GCC version 5.1 included with Fedora 22 is running stricter array > bounds checks which are throwing up errors in a number of components > in the DPDK code. This patchset fixes these errors to allow compilation > with GCC on Fedora 22. > > Example error: > == Build lib/librte_eal/linuxapp/eal > CC eal_memory.o > /home/bruce/dpdk.org/lib/librte_eal/linuxapp/eal/eal_memory.c: In function 'rte_eal_hugepage_init': > /home/bruce/dpdk.org/lib/librte_eal/linuxapp/eal/eal_memory.c:1193:35: error: array subscript is above array bounds [-Werror=array-bounds] > internal_config.hugepage_info[j].hugepage_sz) { > ^ > compilation terminated due to -Wfatal-errors. > > Bruce Richardson (4): > eal: fix compile on Fedora 22 (GCC 5.1) > ip_frag: fix compile on Fedora 22 (GCC 5.1) > i40e: fix compile on Fedora 22 (GCC 5.1) > null: fix compile on Fedora 22 (GCC 5.1) > > drivers/net/i40e/i40e_fdir.c | 2 +- > drivers/net/null/rte_eth_null.c | 12 ++++++++---- > lib/librte_eal/linuxapp/eal/eal_memory.c | 4 +++- > lib/librte_ip_frag/ip_frag_common.h | 2 +- > 4 files changed, 13 insertions(+), 7 deletions(-) > > -- > 2.4.1 > > Series Acked-by: Neil Horman