From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pd0-f178.google.com (mail-pd0-f178.google.com [209.85.192.178]) by dpdk.org (Postfix) with ESMTP id 3BA501DB1 for ; Sat, 30 May 2015 17:47:58 +0200 (CEST) Received: by pdbqa5 with SMTP id qa5so75002537pdb.0 for ; Sat, 30 May 2015 08:47:57 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-type:content-transfer-encoding; bh=5RUXB07evmbmv84UW4sp+zPQ0arY40N9YLJeaFaZjLI=; b=ZrxaTMH6JC26DlMbErXxiJZA/m2TK6w+7Vz5jXURqdR+biktTmeR4xzYIuIrA04h4W 7DoSXDoCZb6DsCzKOZZ2N0v4/IZ+eCLg/VP21eG1OVg4rA1WM5ccVF9w6Z+C5j0wNP9Y YdeqtCUURq5v/cG5h4k6YO1bh35hM4qjfO+Yjtz/Hw+i+8OVvwqk/RE3x51kqoOp3/om f3ldV+PLWvCwftk3WIFNDyqcURMFuQ1gRqToKHhBebGyz32djgBpEm9c8XwjPCJuEG1t cdwxvRc69YxLCXW5xym09boOGHcjJNn5nnBorMl8SCq5npAcxkeSv3JekxbfnumImudU lBKQ== X-Gm-Message-State: ALoCoQnDOx9XNpz3mpP1JWPgrytWkUYkXxwjMzC/wyUHR1fKm2BQFv+w5qzGGamipWm//NQo8t2+ X-Received: by 10.70.138.38 with SMTP id qn6mr24495111pdb.119.1433000877425; Sat, 30 May 2015 08:47:57 -0700 (PDT) Received: from urahara (static-50-53-82-155.bvtn.or.frontiernet.net. [50.53.82.155]) by mx.google.com with ESMTPSA id ae9sm9108778pac.25.2015.05.30.08.47.56 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 30 May 2015 08:47:57 -0700 (PDT) Date: Sat, 30 May 2015 08:48:00 -0700 From: Stephen Hemminger To: Liang-Min Larry Wang Message-ID: <20150530084800.56e3585e@urahara> In-Reply-To: <1432946276-9424-3-git-send-email-liang-min.wang@intel.com> References: <1432946276-9424-1-git-send-email-liang-min.wang@intel.com> <1432946276-9424-3-git-send-email-liang-min.wang@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH 2/2] ethtool: add new library to provide ethtool-alike APIs X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 30 May 2015 15:47:58 -0000 On Fri, 29 May 2015 20:37:56 -0400 Liang-Min Larry Wang wrote: > adding a new library based upon ethdev APIs to provide API's that bear > the same functionality as ethtool_ops (linux/ethtool.h) and net_device_ops > (linux/netdevice.h). The API's for ethtool like things are valuable, but please contain it more. I think you should contain this to only those things which are in the original Linux ethtool. Adding yet another layer that calls DPDK for open/close/start stop just adds more layers with out providing any value. The ones I would keep: get_driverinfo get_link The ones I would add: cmd - for speed/duplex negotiation eeprom - for eeprom access eee - for energy awareness coalesce - for packet coalescing ringparam - to allow changing ring parameters (existing rx config model is limiting) pauseparam - existing flow control in DPDK is mess gstrings/stats - map to XSTATS test - for offline tests dump - for register dump features - control offload features perm_addr - base mac address