From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0b-000f0801.pphosted.com (mx0b-000f0801.pphosted.com [67.231.152.113]) by dpdk.org (Postfix) with ESMTP id 00DBA58C3 for ; Mon, 1 Jun 2015 16:11:24 +0200 (CEST) Received: from pps.filterd (m0000700.ppops.net [127.0.0.1]) by mx0b-000f0801.pphosted.com (8.14.7/8.14.7) with SMTP id t51DukIk000384; Mon, 1 Jun 2015 07:11:23 -0700 Received: from brmwp-exchub01.corp.brocade.com ([208.47.132.227]) by mx0b-000f0801.pphosted.com with ESMTP id 1urrqpr0v9-3 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NOT); Mon, 01 Jun 2015 07:11:23 -0700 Received: from BRMWP-EXMB11.corp.brocade.com (172.16.59.77) by BRMWP-EXCHUB01.corp.brocade.com (172.16.186.99) with Microsoft SMTP Server (TLS) id 14.3.123.3; Mon, 1 Jun 2015 08:11:11 -0600 Received: from urahara (10.72.40.55) by BRMWP-EXMB11.corp.brocade.com (172.16.59.77) with Microsoft SMTP Server (TLS) id 15.0.1044.25; Mon, 1 Jun 2015 08:11:10 -0600 Date: Mon, 1 Jun 2015 07:11:12 -0700 From: Stephen Hemminger To: Cunming Liang Message-ID: <20150601071112.32e26604@urahara> In-Reply-To: <1432889125-20255-13-git-send-email-cunming.liang@intel.com> References: <1432198563-16334-1-git-send-email-cunming.liang@intel.com> <1432889125-20255-1-git-send-email-cunming.liang@intel.com> <1432889125-20255-13-git-send-email-cunming.liang@intel.com> Organization: Brocade MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-ClientProxiedBy: hq1wp-excas12.corp.brocade.com (10.70.38.22) To BRMWP-EXMB11.corp.brocade.com (172.16.59.77) X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:5.14.151, 1.0.33, 0.0.0000 definitions=2015-06-01_03:2015-05-29,2015-06-01,1970-01-01 signatures=0 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 suspectscore=1 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=7.0.1-1402240000 definitions=main-1506010175 X-Mailman-Approved-At: Mon, 01 Jun 2015 16:13:58 +0200 Cc: dev@dpdk.org, liang-min.wang@intel.com Subject: Re: [dpdk-dev] [PATCH v9 12/12] abi: fix v2.1 abi broken issue X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 01 Jun 2015 14:11:25 -0000 On Fri, 29 May 2015 16:45:25 +0800 Cunming Liang wrote: > RTE_EAL_RX_INTR will be removed from v2.2. It's only used to avoid ABI(unannounced) broken in v2.1. > The usrs should make sure understand the impact before turning on the feature. > There are two abi changes required in this interrupt patch set. > They're 1) struct rte_intr_handle; 2) struct rte_intr_conf. > > Signed-off-by: Cunming Liang > --- While merging for testing I discovered another minor issue. The patch order here is a problem. The intermediate steps won't build until this last patch is applied. In order to allow git bisect to be useful, it is important that every commit done in the upstream version build and work. This series does not seem to build until this last patch is applied. Maybe it should just be first?