From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-000f0801.pphosted.com (mx0a-000f0801.pphosted.com [67.231.144.122]) by dpdk.org (Postfix) with ESMTP id 9CB07BE7C for ; Tue, 2 Jun 2015 18:24:10 +0200 (CEST) Received: from pps.filterd (m0000542.ppops.net [127.0.0.1]) by mx0a-000f0801.pphosted.com (8.14.7/8.14.7) with SMTP id t51NjxkO010078; Tue, 2 Jun 2015 09:24:09 -0700 Received: from hq1wp-exchub01.corp.brocade.com ([144.49.131.13]) by mx0a-000f0801.pphosted.com with ESMTP id 1urye41t8j-1 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NOT); Tue, 02 Jun 2015 09:24:09 -0700 Received: from BRMWP-EXCHUB01.corp.brocade.com (172.16.186.99) by HQ1WP-EXCHUB01.corp.brocade.com (10.70.36.101) with Microsoft SMTP Server (TLS) id 14.3.123.3; Tue, 2 Jun 2015 09:23:37 -0700 Received: from BRMWP-EXMB11.corp.brocade.com (172.16.59.77) by BRMWP-EXCHUB01.corp.brocade.com (172.16.186.99) with Microsoft SMTP Server (TLS) id 14.3.123.3; Tue, 2 Jun 2015 10:22:59 -0600 Received: from urahara (10.252.8.17) by BRMWP-EXMB11.corp.brocade.com (172.16.59.77) with Microsoft SMTP Server (TLS) id 15.0.1044.25; Tue, 2 Jun 2015 10:22:58 -0600 Date: Tue, 2 Jun 2015 09:23:00 -0700 From: Stephen Hemminger To: Cunming Liang Message-ID: <20150602092300.7a615e7e@urahara> In-Reply-To: <1433228006-24661-4-git-send-email-cunming.liang@intel.com> References: <1432889125-20255-1-git-send-email-cunming.liang@intel.com> <1433228006-24661-1-git-send-email-cunming.liang@intel.com> <1433228006-24661-4-git-send-email-cunming.liang@intel.com> Organization: Brocade MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-ClientProxiedBy: hq1wp-excas12.corp.brocade.com (10.70.38.22) To BRMWP-EXMB11.corp.brocade.com (172.16.59.77) X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:5.13.68, 1.0.33, 0.0.0000 definitions=2015-03-05_07:2015-03-05,2015-03-05,1970-01-01 signatures=0 X-Proofpoint-Spam-Details: rule=notspam policy=default score=1 spamscore=1 suspectscore=1 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=7.0.1-1402240000 definitions=main-1503050223 X-Mailman-Approved-At: Tue, 02 Jun 2015 18:27:04 +0200 Cc: dev@dpdk.org, liang-min.wang@intel.com Subject: Re: [dpdk-dev] [PATCH v10 03/13] eal/linux: add API to set rx interrupt event monitor X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 02 Jun 2015 16:24:11 -0000 On Tue, 2 Jun 2015 14:53:16 +0800 Cunming Liang wrote: > + bytes_read = read(fd, &buf, bytes_read); > + if (bytes_read < 0) { > + if (errno == EINTR || errno == EWOULDBLOCK || > + errno == EAGAIN) > + continue; > + RTE_LOG(ERR, EAL, "Error reading from file " > + "descriptor %d: %s\n", fd, It is better not to split strings across multiple lines because sometimes developers need to use tools like grep to find which file has the error message. Instead: RTE_LOG(ERR, EAL, "Error reading from fd %d: %s\n", fd, strerror(errno));