From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <bruce.richardson@intel.com>
Received: from mga03.intel.com (mga03.intel.com [134.134.136.65])
 by dpdk.org (Postfix) with ESMTP id A87E15A56
 for <dev@dpdk.org>; Thu,  4 Jun 2015 11:33:34 +0200 (CEST)
Received: from orsmga001.jf.intel.com ([10.7.209.18])
 by orsmga103.jf.intel.com with ESMTP; 04 Jun 2015 02:33:33 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.13,552,1427785200"; d="scan'208";a="705181050"
Received: from bricha3-mobl3.ger.corp.intel.com ([10.237.220.135])
 by orsmga001.jf.intel.com with SMTP; 04 Jun 2015 02:33:31 -0700
Received: by  (sSMTP sendmail emulation); Thu, 04 Jun 2015 10:33:30 +0025
Date: Thu, 4 Jun 2015 10:33:30 +0100
From: Bruce Richardson <bruce.richardson@intel.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Message-ID: <20150604093330.GA4968@bricha3-MOBL3>
References: <1431531022-29697-2-git-send-email-bruce.richardson@intel.com>
 <1433339893-19603-1-git-send-email-bruce.richardson@intel.com>
 <1627508.1SMo23WCxz@xps13>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1627508.1SMo23WCxz@xps13>
Organization: Intel Shannon Ltd.
User-Agent: Mutt/1.5.23 (2014-03-12)
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v2] doc: add coding standards documentation
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 04 Jun 2015 09:33:35 -0000

On Wed, Jun 03, 2015 at 07:35:32PM +0200, Thomas Monjalon wrote:
> 2015-06-03 14:58, Bruce Richardson:
> > Add coding standards document to guides directory. This document
> > codifies the current DPDK C coding conventions, to make it easier for
> > contributors to see the format their code should be in.
> > 
> > Signed-off-by: Siobhan Butler <siobhan.a.butler@intel.com>
> > Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> > 
> > ---
> > 
> > Updates in V2:
> > * Fixed file creation mode
> > * Removed blank line at end of file
> > * Adjusted coding blocks to be C language, rather than console, so as to
> >   have correct syntax highlighting.
> > * Shortened longer lines by breaking lines at sentence - and
> >   occasionally comma - boundaries.
> > ---
> >  doc/guides/coding_standards/index.rst | 861 ++++++++++++++++++++++++++++++++++
> >  doc/guides/index.rst                  |   1 +
> 
> This version seems very good.
> However, I have the feeling that coding_standards/ is not a good name:
> 	- "standards" word is a bit strong ;
> 	- "coding" seems too restrictive, maybe we would like to put
> more guidelines in this directory (thinking about file tree, compat and tests).
> Do you agree I rename it to guidelines/coding_style.rst?

No problem, go with it!