From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <bruce.richardson@intel.com>
Received: from mga14.intel.com (mga14.intel.com [192.55.52.115])
 by dpdk.org (Postfix) with ESMTP id D8F5058DD
 for <dev@dpdk.org>; Thu,  4 Jun 2015 15:36:33 +0200 (CEST)
Received: from orsmga002.jf.intel.com ([10.7.209.21])
 by fmsmga103.fm.intel.com with ESMTP; 04 Jun 2015 06:36:33 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.13,552,1427785200"; d="scan'208";a="740916314"
Received: from bricha3-mobl3.ger.corp.intel.com ([10.237.220.135])
 by orsmga002.jf.intel.com with SMTP; 04 Jun 2015 06:36:30 -0700
Received: by  (sSMTP sendmail emulation); Thu, 04 Jun 2015 14:36:30 +0025
Date: Thu, 4 Jun 2015 14:36:29 +0100
From: Bruce Richardson <bruce.richardson@intel.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Message-ID: <20150604133629.GA10532@bricha3-MOBL3>
References: <1431531022-29697-2-git-send-email-bruce.richardson@intel.com>
 <1627508.1SMo23WCxz@xps13> <20150604093330.GA4968@bricha3-MOBL3>
 <6992797.Cr2pidrT3F@xps13>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <6992797.Cr2pidrT3F@xps13>
Organization: Intel Shannon Ltd.
User-Agent: Mutt/1.5.23 (2014-03-12)
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v2] doc: add coding standards documentation
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 04 Jun 2015 13:36:34 -0000

On Thu, Jun 04, 2015 at 11:49:49AM +0200, Thomas Monjalon wrote:
> 2015-06-04 10:33, Bruce Richardson:
> > On Wed, Jun 03, 2015 at 07:35:32PM +0200, Thomas Monjalon wrote:
> > > 2015-06-03 14:58, Bruce Richardson:
> > > > Add coding standards document to guides directory. This document
> > > > codifies the current DPDK C coding conventions, to make it easier for
> > > > contributors to see the format their code should be in.
> > > > 
> > > > Signed-off-by: Siobhan Butler <siobhan.a.butler@intel.com>
> > > > Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> > > > 
> > > > ---
> > > > 
> > > > Updates in V2:
> > > > * Fixed file creation mode
> > > > * Removed blank line at end of file
> > > > * Adjusted coding blocks to be C language, rather than console, so as to
> > > >   have correct syntax highlighting.
> > > > * Shortened longer lines by breaking lines at sentence - and
> > > >   occasionally comma - boundaries.
> > > > ---
> > > >  doc/guides/coding_standards/index.rst | 861 ++++++++++++++++++++++++++++++++++
> > > >  doc/guides/index.rst                  |   1 +
> > > 
> > > This version seems very good.
> > > However, I have the feeling that coding_standards/ is not a good name:
> > > 	- "standards" word is a bit strong ;
> > > 	- "coding" seems too restrictive, maybe we would like to put
> > > more guidelines in this directory (thinking about file tree, compat and tests).
> > > Do you agree I rename it to guidelines/coding_style.rst?
> > 
> > No problem, go with it!
> 
> Acked-by: Thomas Monjalon <thomas.monjalon@6wind.com>
> 
> Applied, thanks

Great!

General request to mailing list: While I've done my best with this doc to 
cover the current practice of coding in DPDK, I know there are lots of areas of
style and convention I must have missed. Please submit patches to help fill in the
gaps in this doc. :-)

Thanks!
/Bruce