DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH 1/3] kni: minor opto
@ 2015-06-03 19:18 Jay Rolette
  2015-06-03 19:18 ` [dpdk-dev] [PATCH 2/3] " Jay Rolette
                   ` (3 more replies)
  0 siblings, 4 replies; 16+ messages in thread
From: Jay Rolette @ 2015-06-03 19:18 UTC (permalink / raw)
  To: dev

Don't need the 'safe' version of list_for_each_entry() if you aren't deleting from the list as you iterate over it

Signed-off-by: Jay Rolette <rolette@infiniteio.com>
---
 lib/librte_eal/linuxapp/kni/kni_misc.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/lib/librte_eal/linuxapp/kni/kni_misc.c b/lib/librte_eal/linuxapp/kni/kni_misc.c
index 1935d32..312f196 100644
--- a/lib/librte_eal/linuxapp/kni/kni_misc.c
+++ b/lib/librte_eal/linuxapp/kni/kni_misc.c
@@ -213,13 +213,12 @@ static int
 kni_thread_single(void *unused)
 {
 	int j;
-	struct kni_dev *dev, *n;
+	struct kni_dev *dev;
 
 	while (!kthread_should_stop()) {
 		down_read(&kni_list_lock);
 		for (j = 0; j < KNI_RX_LOOP_NUM; j++) {
-			list_for_each_entry_safe(dev, n,
-					&kni_list_head, list) {
+			list_for_each_entry(dev, &kni_list_head, list) {
 #ifdef RTE_KNI_VHOST
 				kni_chk_vhost_rx(dev);
 #else
-- 
2.3.2 (Apple Git-55)

^ permalink raw reply	[flat|nested] 16+ messages in thread
* [dpdk-dev] [PATCH 1/3] kni: minor opto
@ 2015-06-03 19:07 Jay Rolette
  2015-06-16  1:12 ` Zhang, Helin
  0 siblings, 1 reply; 16+ messages in thread
From: Jay Rolette @ 2015-06-03 19:07 UTC (permalink / raw)
  To: dev

Don't need the 'safe' version of list_for_each_entry() if you aren't deleting from the list as you iterate over it

Signed-off-by: Jay Rolette <rolette@infiniteio.com>
---
 lib/librte_eal/linuxapp/kni/kni_misc.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/lib/librte_eal/linuxapp/kni/kni_misc.c b/lib/librte_eal/linuxapp/kni/kni_misc.c
index 1935d32..312f196 100644
--- a/lib/librte_eal/linuxapp/kni/kni_misc.c
+++ b/lib/librte_eal/linuxapp/kni/kni_misc.c
@@ -213,13 +213,12 @@ static int
 kni_thread_single(void *unused)
 {
 	int j;
-	struct kni_dev *dev, *n;
+	struct kni_dev *dev;
 
 	while (!kthread_should_stop()) {
 		down_read(&kni_list_lock);
 		for (j = 0; j < KNI_RX_LOOP_NUM; j++) {
-			list_for_each_entry_safe(dev, n,
-					&kni_list_head, list) {
+			list_for_each_entry(dev, &kni_list_head, list) {
 #ifdef RTE_KNI_VHOST
 				kni_chk_vhost_rx(dev);
 #else
-- 
2.3.2 (Apple Git-55)

^ permalink raw reply	[flat|nested] 16+ messages in thread

end of thread, other threads:[~2015-06-16 15:21 UTC | newest]

Thread overview: 16+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-06-03 19:18 [dpdk-dev] [PATCH 1/3] kni: minor opto Jay Rolette
2015-06-03 19:18 ` [dpdk-dev] [PATCH 2/3] " Jay Rolette
2015-06-04 13:44   ` Bruce Richardson
2015-06-15  2:21   ` Zhang, Helin
2015-06-03 19:18 ` [dpdk-dev] [PATCH 3/3] kni: rx loop was using the wrong counter Jay Rolette
2015-06-04 13:47   ` Bruce Richardson
2015-06-04 13:39 ` [dpdk-dev] [PATCH 1/3] kni: minor opto Bruce Richardson
2015-06-04 13:40   ` Bruce Richardson
2015-06-04 15:02     ` Thomas Monjalon
2015-06-04 15:05       ` Bruce Richardson
2015-06-15  2:07 ` Zhang, Helin
2015-06-15 12:42   ` Jay Rolette
2015-06-16  1:15     ` Zhang, Helin
2015-06-16 15:20       ` Thomas Monjalon
  -- strict thread matches above, loose matches on Subject: below --
2015-06-03 19:07 Jay Rolette
2015-06-16  1:12 ` Zhang, Helin

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).