From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id E9C01C33A for ; Thu, 4 Jun 2015 15:44:22 +0200 (CEST) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga102.jf.intel.com with ESMTP; 04 Jun 2015 06:44:21 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.13,552,1427785200"; d="scan'208";a="740920535" Received: from bricha3-mobl3.ger.corp.intel.com ([10.237.220.135]) by orsmga002.jf.intel.com with SMTP; 04 Jun 2015 06:44:19 -0700 Received: by (sSMTP sendmail emulation); Thu, 04 Jun 2015 14:44:18 +0025 Date: Thu, 4 Jun 2015 14:44:18 +0100 From: Bruce Richardson To: Jay Rolette Message-ID: <20150604134418.GD10532@bricha3-MOBL3> References: <1433359137-12720-1-git-send-email-rolette@infiniteio.com> <1433359137-12720-2-git-send-email-rolette@infiniteio.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1433359137-12720-2-git-send-email-rolette@infiniteio.com> Organization: Intel Shannon Ltd. User-Agent: Mutt/1.5.23 (2014-03-12) Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH 2/3] kni: minor opto X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 04 Jun 2015 13:44:23 -0000 On Wed, Jun 03, 2015 at 02:18:56PM -0500, Jay Rolette wrote: > No reason to check out many entries are in kni->rx_q prior to > actually pulling them from the fifo. You can't dequeue more than > are there anyway. Max entries to dequeue is either the max batch > size or however much space is available on kni->free_q (lesser of the two) > > Signed-off-by: Jay Rolette Again title needs to be made clearer. Otherwise ok. Acked-by: Bruce Richardson