From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <bruce.richardson@intel.com>
Received: from mga11.intel.com (mga11.intel.com [192.55.52.93])
 by dpdk.org (Postfix) with ESMTP id 7BEE3C384
 for <dev@dpdk.org>; Thu,  4 Jun 2015 17:05:55 +0200 (CEST)
Received: from orsmga001.jf.intel.com ([10.7.209.18])
 by fmsmga102.fm.intel.com with ESMTP; 04 Jun 2015 08:05:54 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.13,553,1427785200"; d="scan'208";a="705333228"
Received: from bricha3-mobl3.ger.corp.intel.com ([10.237.220.135])
 by orsmga001.jf.intel.com with SMTP; 04 Jun 2015 08:05:52 -0700
Received: by  (sSMTP sendmail emulation); Thu, 04 Jun 2015 16:05:51 +0025
Date: Thu, 4 Jun 2015 16:05:51 +0100
From: Bruce Richardson <bruce.richardson@intel.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Message-ID: <20150604150551.GA10280@bricha3-MOBL3>
References: <1433359137-12720-1-git-send-email-rolette@infiniteio.com>
 <20150604133916.GB10532@bricha3-MOBL3>
 <20150604134056.GC10532@bricha3-MOBL3> <1991422.2bqYBlViPU@xps13>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1991422.2bqYBlViPU@xps13>
Organization: Intel Shannon Ltd.
User-Agent: Mutt/1.5.23 (2014-03-12)
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH 1/3] kni: minor opto
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 04 Jun 2015 15:05:55 -0000

On Thu, Jun 04, 2015 at 05:02:06PM +0200, Thomas Monjalon wrote:
> 2015-06-04 14:40, Bruce Richardson:
> > On Thu, Jun 04, 2015 at 02:39:17PM +0100, Bruce Richardson wrote:
> > > On Wed, Jun 03, 2015 at 02:18:55PM -0500, Jay Rolette wrote:
> > > > Don't need the 'safe' version of list_for_each_entry() if you aren't deleting from the list as you iterate over it
> > > > 
> > > > Signed-off-by: Jay Rolette <rolette@infiniteio.com>
> > > 
> > > Acked-by: Bruce Richardson <bruce.richardson@intel.com>
> > > 
> > Forgot to mention though, that the commit title needs to be a little more
> > descriptive.
> 
> So you should not ack this version ;)
> 
Code and text description looked fine, so I thought an ack otherwise appropriate.
However, I will refrain from doing so in future :-)

/Bruce