From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.tuxdriver.com (charlotte.tuxdriver.com [70.61.120.58]) by dpdk.org (Postfix) with ESMTP id 4226A4A63 for ; Fri, 5 Jun 2015 12:30:32 +0200 (CEST) Received: from hmsreliant.think-freely.org ([2001:470:8:a08:7aac:c0ff:fec2:933b] helo=localhost) by smtp.tuxdriver.com with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.63) (envelope-from ) id 1Z0otL-0006QQ-Bj; Fri, 05 Jun 2015 06:30:27 -0400 Date: Fri, 5 Jun 2015 06:30:17 -0400 From: Neil Horman To: "Zhang, Helin" Message-ID: <20150605103017.GA10308@hmsreliant.think-freely.org> References: <1433379638-32715-1-git-send-email-helin.zhang@intel.com> <1433379638-32715-2-git-send-email-helin.zhang@intel.com> <20150604130510.GB24585@hmsreliant.think-freely.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) X-Spam-Score: -2.9 (--) X-Spam-Status: No Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH 1/6] ethdev: add an field for querying hash key size X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 05 Jun 2015 10:30:32 -0000 On Fri, Jun 05, 2015 at 06:21:52AM +0000, Zhang, Helin wrote: > Hi Neil > > Yes, thank you very much for the comments! > I realized the ABI issue after I sent out the patch. I think even I put the new one the end of this structure, it may also have issue. > I'd like to have this change announced and then get it merged. That means I'd like to make this change and follow the policy and process. > > Regards, > Helin > Ok, sounds good. Thanks! Neil > > -----Original Message----- > > From: Neil Horman [mailto:nhorman@tuxdriver.com] > > Sent: Thursday, June 4, 2015 9:05 PM > > To: Zhang, Helin > > Cc: dev@dpdk.org > > Subject: Re: [dpdk-dev] [PATCH 1/6] ethdev: add an field for querying hash key > > size > > > > On Thu, Jun 04, 2015 at 09:00:33AM +0800, Helin Zhang wrote: > > > To support querying hash key size per port, an new field of > > > 'hash_key_size' was added in 'struct rte_eth_dev_info' for storing > > > hash key size in bytes. > > > > > > Signed-off-by: Helin Zhang > > > --- > > > lib/librte_ether/rte_ethdev.h | 1 + > > > 1 file changed, 1 insertion(+) > > > > > > diff --git a/lib/librte_ether/rte_ethdev.h > > > b/lib/librte_ether/rte_ethdev.h index 16dbe00..004b05a 100644 > > > --- a/lib/librte_ether/rte_ethdev.h > > > +++ b/lib/librte_ether/rte_ethdev.h > > > @@ -916,6 +916,7 @@ struct rte_eth_dev_info { > > > uint16_t max_vmdq_pools; /**< Maximum number of VMDq pools. */ > > > uint32_t rx_offload_capa; /**< Device RX offload capabilities. */ > > > uint32_t tx_offload_capa; /**< Device TX offload capabilities. */ > > > + uint8_t hash_key_size; /**< Hash key size in bytes */ > > > uint16_t reta_size; > > > /**< Device redirection table size, the total number of entries. */ > > > /** Bit mask of RSS offloads, the bit offset also means flow type */ > > > -- > > > 1.9.3 > > > > > > > > > > You'll need to at least move this to the end of the structure to avoid ABI breakage, > > but even then, since the examples statically allocate this struct on the stack, you > > need to worry about previously compiled applications not having enough space > > allocated. Is there a hole in the struct that this can fit into to avoid changing the > > other member offsets? > > Neil > >