From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qg0-f49.google.com (mail-qg0-f49.google.com [209.85.192.49]) by dpdk.org (Postfix) with ESMTP id 9DC8A3796 for ; Wed, 10 Jun 2015 02:29:53 +0200 (CEST) Received: by qgf75 with SMTP id 75so11163188qgf.1 for ; Tue, 09 Jun 2015 17:29:52 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-type:content-transfer-encoding; bh=5w5nzYUL2GrjM5DEyQlKK4CGJgoW3xd9NDd5cwZAYgM=; b=A+q/YRDcLTGmubBPYbVc0SYMca9QZNxzbWTal6ZO5E/VPH/bPrJiczMyhFf56BJd/1 KoHXmTLJ8duDkBLPSriyZZEZt2KvyANN1uiE2STq6YvMvKtV6Y7sc821qdSo89c0g8lR IFjCnV9hl3Kdxn3uLeMdNPnFKXfm8dEHQ45dsoQWh2Q6CgWZhpUhKfoX9Of3DZQtQgK9 ljnr1+8JhqWcINSLCJ1KAfBPKktJbFBRbAcZNS6LNC62PUdFTih0V/h0sAcZO2IDALXV st2ThO/nt7QRN/eJxdtN6F0wLfmssdZVn+Zam8LgUpEKl/nzcZxtUOBdFMOUPhZcCzgd PxzQ== X-Gm-Message-State: ALoCoQmh+jl45IV6vsc3jyUhXBcVRY2bNfZ04MS4wDkMFRbhRc2pRTUb2KAUPQOAR6zlzh9A0LNM X-Received: by 10.140.48.129 with SMTP id o1mr418031qga.21.1433896192149; Tue, 09 Jun 2015 17:29:52 -0700 (PDT) Received: from urahara (static-50-53-82-155.bvtn.or.frontiernet.net. [50.53.82.155]) by mx.google.com with ESMTPSA id j60sm3447232qge.38.2015.06.09.17.29.51 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 09 Jun 2015 17:29:51 -0700 (PDT) Date: Tue, 9 Jun 2015 17:29:54 -0700 From: Stephen Hemminger To: Maryam Tahhan Message-ID: <20150609172954.173d26d0@urahara> In-Reply-To: <1433862646-91880-2-git-send-email-maryam.tahhan@intel.com> References: <1433862646-91880-1-git-send-email-maryam.tahhan@intel.com> <1433862646-91880-2-git-send-email-maryam.tahhan@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v2 1/7] ethdev: add additional error stats X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 10 Jun 2015 00:29:54 -0000 On Tue, 9 Jun 2015 16:10:40 +0100 Maryam Tahhan wrote: > Add MAC error and drop statistics to struct rte_eth_stats and the > extended stats. > Signed-off-by: Maryam Tahhan > --- > lib/librte_ether/rte_ethdev.c | 4 ++++ > lib/librte_ether/rte_ethdev.h | 4 ++++ > 2 files changed, 8 insertions(+) > > diff --git a/lib/librte_ether/rte_ethdev.c b/lib/librte_ether/rte_ethdev.c > index 5a94654..a439b4a 100644 > --- a/lib/librte_ether/rte_ethdev.c > +++ b/lib/librte_ether/rte_ethdev.c > @@ -136,6 +136,10 @@ static const struct rte_eth_xstats_name_off rte_stats_strings[] = { > {"rx_flow_control_xon", offsetof(struct rte_eth_stats, rx_pause_xon)}, > {"tx_flow_control_xoff", offsetof(struct rte_eth_stats, tx_pause_xoff)}, > {"rx_flow_control_xoff", offsetof(struct rte_eth_stats, rx_pause_xoff)}, > + {"rx_mac_err", offsetof(struct rte_eth_stats, imacerr)}, > + {"rx_phy_err", offsetof(struct rte_eth_stats, iphyerr)}, > + {"tx_drops", offsetof(struct rte_eth_stats, odrop)}, > + {"rx_drops", offsetof(struct rte_eth_stats, idrop)} Are these really generic enough to put them in ethdev?