From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 1D3F2C2FC for ; Fri, 12 Jun 2015 16:00:27 +0200 (CEST) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga103.fm.intel.com with ESMTP; 12 Jun 2015 07:00:26 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.13,602,1427785200"; d="scan'208";a="709845570" Received: from bricha3-mobl3.ger.corp.intel.com ([10.243.20.21]) by orsmga001.jf.intel.com with SMTP; 12 Jun 2015 07:00:24 -0700 Received: by (sSMTP sendmail emulation); Fri, 12 Jun 2015 15:00:23 +0025 Date: Fri, 12 Jun 2015 15:00:23 +0100 From: Bruce Richardson To: Panu Matilainen Message-ID: <20150612140023.GA6688@bricha3-MOBL3> References: <1434086314-14371-1-git-send-email-stephen@networkplumber.org> <1434086314-14371-2-git-send-email-stephen@networkplumber.org> <557A724F.5090801@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <557A724F.5090801@redhat.com> Organization: Intel Shannon Ltd. User-Agent: Mutt/1.5.23 (2014-03-12) Cc: dev@dpdk.org, Stephen Hemminger Subject: Re: [dpdk-dev] [PATCH 1/3] rte_ring: remove deprecated functions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 12 Jun 2015 14:00:28 -0000 On Fri, Jun 12, 2015 at 08:46:55AM +0300, Panu Matilainen wrote: > On 06/12/2015 08:18 AM, Stephen Hemminger wrote: > >From: Stephen Hemminger > > > >These were deprecated in 2.0 so remove them from 2.1 > > > >Signed-off-by: Stephen Hemminger > >--- > > drivers/net/ring/rte_eth_ring.c | 55 ------------------------------- > > drivers/net/ring/rte_eth_ring_version.map | 2 -- > > 2 files changed, 57 deletions(-) > > > [...] > >diff --git a/drivers/net/ring/rte_eth_ring_version.map b/drivers/net/ring/rte_eth_ring_version.map > >index 8ad107d..0875e25 100644 > >--- a/drivers/net/ring/rte_eth_ring_version.map > >+++ b/drivers/net/ring/rte_eth_ring_version.map > >@@ -2,8 +2,6 @@ DPDK_2.0 { > > global: > > > > rte_eth_from_rings; > >- rte_eth_ring_pair_attach; > >- rte_eth_ring_pair_create; > > > > local: *; > > }; > > Removing symbols is an ABI break so it additionally requires a soname bump > for this library. > > In addition, simply due to being the first library to do so, it'll also then > break the combined shared library as is currently is. Mind you, this is not > an objection at all, the need to change to a linker script approach has > always been a matter of time. > > - Panu - > Also, patch title should be prefixed with "ring pmd" or "drivers/net/ring" rather than rte_ring, since this is a patch for the ring pmd, not the rte_ring library. /Bruce