From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id C194DADA7 for ; Fri, 12 Jun 2015 16:22:32 +0200 (CEST) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga102.fm.intel.com with ESMTP; 12 Jun 2015 07:22:31 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.13,602,1427785200"; d="scan'208";a="742171456" Received: from bricha3-mobl3.ger.corp.intel.com ([10.243.20.21]) by fmsmga002.fm.intel.com with SMTP; 12 Jun 2015 07:22:27 -0700 Received: by (sSMTP sendmail emulation); Fri, 12 Jun 2015 15:22:25 +0025 Date: Fri, 12 Jun 2015 15:22:25 +0100 From: Bruce Richardson To: Thomas Monjalon Message-ID: <20150612142224.GA6032@bricha3-MOBL3> References: <1434086314-14371-1-git-send-email-stephen@networkplumber.org> <557A724F.5090801@redhat.com> <20150612140023.GA6688@bricha3-MOBL3> <3193080.9j8deXXLB3@xps13> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3193080.9j8deXXLB3@xps13> Organization: Intel Shannon Ltd. User-Agent: Mutt/1.5.23 (2014-03-12) Cc: dev@dpdk.org, Stephen Hemminger Subject: Re: [dpdk-dev] [PATCH 1/3] rte_ring: remove deprecated functions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 12 Jun 2015 14:22:33 -0000 On Fri, Jun 12, 2015 at 04:15:10PM +0200, Thomas Monjalon wrote: > 2015-06-12 15:00, Bruce Richardson: > > On Fri, Jun 12, 2015 at 08:46:55AM +0300, Panu Matilainen wrote: > > > On 06/12/2015 08:18 AM, Stephen Hemminger wrote: > > Also, patch title should be prefixed with "ring pmd" or "drivers/net/ring" rather > > than rte_ring, since this is a patch for the ring pmd, not the rte_ring library. > > Previously, there was no difference, it was only "ring". > Prefixes don't include full path nor "pmd". > Is it really important to make a difference in the commit title between ring lib > and ring pmd? Not especially important, no. However, if we are going to have prefixes to indicate what component is affected by a patch, they should at least be unique per component IMHO. /Bruce