From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 74AE7C5B8 for ; Thu, 18 Jun 2015 12:00:31 +0200 (CEST) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga102.jf.intel.com with ESMTP; 18 Jun 2015 03:00:30 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.13,638,1427785200"; d="scan'208";a="745730379" Received: from bricha3-mobl3.ger.corp.intel.com ([10.243.20.21]) by fmsmga002.fm.intel.com with SMTP; 18 Jun 2015 03:00:19 -0700 Received: by (sSMTP sendmail emulation); Thu, 18 Jun 2015 11:00:18 +0025 Date: Thu, 18 Jun 2015 11:00:18 +0100 From: Bruce Richardson To: Thomas Monjalon Message-ID: <20150618100016.GA7972@bricha3-MOBL3> References: <1433250693-23644-1-git-send-email-roman.dementiev@intel.com> <1434475006-13732-1-git-send-email-roman.dementiev@intel.com> <1434475006-13732-2-git-send-email-roman.dementiev@intel.com> <10408699.ljKKKDUIsH@xps13> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <10408699.ljKKKDUIsH@xps13> Organization: Intel Shannon Ltd. User-Agent: Mutt/1.5.23 (2014-03-12) Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v2 1/3] spinlock: add support for HTM lock elision for x86 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 Jun 2015 10:00:31 -0000 On Wed, Jun 17, 2015 at 11:29:49PM +0200, Thomas Monjalon wrote: > 2015-06-16 10:16, Roman Dementiev: > > --- a/lib/librte_eal/common/include/arch/x86/rte_spinlock.h > > +++ b/lib/librte_eal/common/include/arch/x86/rte_spinlock.h > > @@ -39,6 +39,13 @@ extern "C" { > > #endif > > > > #include "generic/rte_spinlock.h" > > +#include "rte_rtm.h" > > +#include "rte_cpuflags.h" > > +#include "rte_branch_prediction.h" > > +#include > > Why using angle brackets for rte_common.h? > > Introducing rte_cpuflags.h in this header breaks the compilation of > the mlx4 pmd with CONFIG_RTE_LIBRTE_MLX4_DEBUG=y. > Indeed, it triggers the -pedantic flag which is not supported by rte_cpuflags.h. > Maybe it's time to fix this header? Do all our headers need to support the pedantic C flag? I don't believe this was a previous requirement for header files. The mlx4 driver appears to be the only place in the dpdk.org codebase where the flag actually appears - and even then the flag disabled in mlx.c where the dpdk headers are actually included. 73 /* DPDK headers don't like -pedantic. */$ 74 #ifdef PEDANTIC$ 75 #pragma GCC diagnostic ignored "-pedantic"$ 76 #endif$ 77 #include $ ..... I'm just not convinced that rte_cpuflags needs to be fixed at all here. /Bruce