Re: [dpdk-dev] [PATCH v3 2/9] lib_vhost: Support multiple queues in virtio dev

[Flavio Leitner <fbl@sysclose.org>]

On Mon, Jun 15, 2015 at 03:56:39PM +0800, Ouyang Changchun wrote:
> Each virtio device could have multiple queues, say 2 or 4, at most 8.
> Enabling this feature allows virtio device/port on guest has the ability to
> use different vCPU to receive/transmit packets from/to each queue.
> 
> In multiple queues mode, virtio device readiness means all queues of
> this virtio device are ready, cleanup/destroy a virtio device also
> requires clearing all queues belong to it.
> 
> Changes in v3:
>   - fix coding style
>   - check virtqueue idx validity
> 
> Changes in v2:
>   - remove the q_num_set api
>   - add the qp_num_get api
>   - determine the queue pair num from qemu message
>   - rework for reset owner message handler
>   - dynamically alloc mem for dev virtqueue
>   - queue pair num could be 0x8000
>   - fix checkpatch errors
> 
> Signed-off-by: Changchun Ouyang <changchun.ouyang@intel.com>
[...]

> diff --git a/lib/librte_vhost/virtio-net.c b/lib/librte_vhost/virtio-net.c
> index fced2ab..aaea7d5 100644
> --- a/lib/librte_vhost/virtio-net.c
> +++ b/lib/librte_vhost/virtio-net.c
> @@ -67,10 +67,10 @@ static struct virtio_net_config_ll *ll_root;
>  #define VHOST_SUPPORTED_FEATURES ((1ULL << VIRTIO_NET_F_MRG_RXBUF) | \
>  				(1ULL << VIRTIO_NET_F_CTRL_VQ) | \
>  				(1ULL << VIRTIO_NET_F_CTRL_RX) | \
> -				(1ULL << VHOST_F_LOG_ALL))
> +				(1ULL << VHOST_F_LOG_ALL)) | \
> +				(1ULL << VIRTIO_NET_F_MQ))

One extra parenthesis after VHOST_F_LOG_ALL
BTW, this series need rebase with latest dpdk.
fbl

>  static uint64_t VHOST_FEATURES = VHOST_SUPPORTED_FEATURES;