From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <fbl@sysclose.org>
Received: from sender163-mail.zoho.com (sender163-mail.zoho.com
 [74.201.84.163]) by dpdk.org (Postfix) with ESMTP id A1133C416
 for <dev@dpdk.org>; Thu, 18 Jun 2015 15:16:49 +0200 (CEST)
Received: from localhost (187.95.124.35 [187.95.124.35]) by mx.zohomail.com
 with SMTPS id 1434633407221334.52486855609266;
 Thu, 18 Jun 2015 06:16:47 -0700 (PDT)
Date: Thu, 18 Jun 2015 10:16:44 -0300
From: Flavio Leitner <fbl@sysclose.org>
To: Ouyang Changchun <changchun.ouyang@intel.com>
Message-ID: <20150618131644.GC2574@x240.home>
References: <1433915549-18571-1-git-send-email-changchun.ouyang@intel.com>
 <1434355006-30583-1-git-send-email-changchun.ouyang@intel.com>
 <1434355006-30583-3-git-send-email-changchun.ouyang@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1434355006-30583-3-git-send-email-changchun.ouyang@intel.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v3 2/9] lib_vhost: Support multiple queues in
 virtio dev
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 18 Jun 2015 13:16:50 -0000

On Mon, Jun 15, 2015 at 03:56:39PM +0800, Ouyang Changchun wrote:
> Each virtio device could have multiple queues, say 2 or 4, at most 8.
> Enabling this feature allows virtio device/port on guest has the ability to
> use different vCPU to receive/transmit packets from/to each queue.
> 
> In multiple queues mode, virtio device readiness means all queues of
> this virtio device are ready, cleanup/destroy a virtio device also
> requires clearing all queues belong to it.
> 
> Changes in v3:
>   - fix coding style
>   - check virtqueue idx validity
> 
> Changes in v2:
>   - remove the q_num_set api
>   - add the qp_num_get api
>   - determine the queue pair num from qemu message
>   - rework for reset owner message handler
>   - dynamically alloc mem for dev virtqueue
>   - queue pair num could be 0x8000
>   - fix checkpatch errors
> 
> Signed-off-by: Changchun Ouyang <changchun.ouyang@intel.com>
[...]

> diff --git a/lib/librte_vhost/virtio-net.c b/lib/librte_vhost/virtio-net.c
> index fced2ab..aaea7d5 100644
> --- a/lib/librte_vhost/virtio-net.c
> +++ b/lib/librte_vhost/virtio-net.c
> @@ -67,10 +67,10 @@ static struct virtio_net_config_ll *ll_root;
>  #define VHOST_SUPPORTED_FEATURES ((1ULL << VIRTIO_NET_F_MRG_RXBUF) | \
>  				(1ULL << VIRTIO_NET_F_CTRL_VQ) | \
>  				(1ULL << VIRTIO_NET_F_CTRL_RX) | \
> -				(1ULL << VHOST_F_LOG_ALL))
> +				(1ULL << VHOST_F_LOG_ALL)) | \
> +				(1ULL << VIRTIO_NET_F_MQ))

One extra parenthesis after VHOST_F_LOG_ALL
BTW, this series need rebase with latest dpdk.
fbl

>  static uint64_t VHOST_FEATURES = VHOST_SUPPORTED_FEATURES;