Re: [dpdk-dev] [PATCHv2 0/5] ethdev: add new API to retrieve RX/TX queue information

[Bruce Richardson <bruce.richardson@intel.com>]

On Thu, Jun 18, 2015 at 02:18:43PM +0100, Konstantin Ananyev wrote:
> Add the ability for the upper layer to query RX/TX queue information.
> Right now supported for:
> ixgbe, i40e, e1000 PMDs.
> 
> Konstantin Ananyev (5):
>   ethdev: add new API to retrieve RX/TX queue information
>   i40e: add support for eth_(rxq|txq)_info_get
>   ixgbe: add support for eth_(rxq|txq)_info_get
>   e1000: add support for eth_(rxq|txq)_info_get
>   testpmd: add new command to display RX/TX queue information
> 
>  app/test-pmd/cmdline.c           | 48 +++++++++++++++++++++++++
>  app/test-pmd/config.c            | 67 ++++++++++++++++++++++++++++++++++
>  app/test-pmd/testpmd.h           |  2 ++
>  drivers/net/e1000/e1000_ethdev.h | 12 +++++++
>  drivers/net/e1000/em_ethdev.c    |  2 ++
>  drivers/net/e1000/em_rxtx.c      | 38 ++++++++++++++++++++
>  drivers/net/e1000/igb_ethdev.c   |  4 +++
>  drivers/net/e1000/igb_rxtx.c     | 36 +++++++++++++++++++
>  drivers/net/i40e/i40e_ethdev.c   |  2 ++
>  drivers/net/i40e/i40e_ethdev.h   |  5 +++
>  drivers/net/i40e/i40e_rxtx.c     | 42 ++++++++++++++++++++++
>  drivers/net/ixgbe/ixgbe_ethdev.c |  4 +++
>  drivers/net/ixgbe/ixgbe_ethdev.h |  6 ++++
>  drivers/net/ixgbe/ixgbe_rxtx.c   | 42 ++++++++++++++++++++++
>  lib/librte_ether/rte_ethdev.c    | 54 ++++++++++++++++++++++++++++
>  lib/librte_ether/rte_ethdev.h    | 77 +++++++++++++++++++++++++++++++++++++++-
>  16 files changed, 440 insertions(+), 1 deletion(-)
> 
> -- 
> 1.8.5.3
> 
Series Acked-by: Bruce Richardson <bruce.richardson@intel.com>

BTW: I'm sure there are plenty of possible suggestions for extensions to these 
functions, but rather than constantly doing new versions to keep adding things
in, can we get the base functionality applied and add in the new info later -
as separate patches? There is space in the structs for more info without 
affecting the ABI.

Regards,
/Bruce