From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from emea01-am1-obe.outbound.protection.outlook.com (mail-am1on0077.outbound.protection.outlook.com [157.56.112.77]) by dpdk.org (Postfix) with ESMTP id 4448AC7B0 for ; Mon, 22 Jun 2015 22:23:41 +0200 (CEST) Authentication-Results: 6wind.com; dkim=none (message not signed) header.d=none; Received: from cchemparathy-ubuntu (12.218.212.162) by HE1PR02MB0793.eurprd02.prod.outlook.com (10.161.118.145) with Microsoft SMTP Server (TLS) id 15.1.195.15; Mon, 22 Jun 2015 20:23:37 +0000 Date: Mon, 22 Jun 2015 13:23:19 -0700 From: Cyril Chemparathy To: Thomas Monjalon Message-ID: <20150622132319.258a5ba3@cchemparathy-ubuntu> In-Reply-To: <29909138.qD9kMyzFYN@xps13> References: <1433516110-11468-1-git-send-email-danielx.t.mrzyglod@intel.com> <3EB4FA525960D640B5BDFFD6A3D8912632371E3A@IRSMSX108.ger.corp.intel.com> <29909138.qD9kMyzFYN@xps13> Organization: EZchip X-Mailer: Claws Mail 3.11.1 (GTK+ 2.24.27; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Originating-IP: [12.218.212.162] X-ClientProxiedBy: CO1PR06CA044.namprd06.prod.outlook.com (10.242.160.34) To HE1PR02MB0793.eurprd02.prod.outlook.com (25.161.118.145) X-Microsoft-Exchange-Diagnostics: 1; HE1PR02MB0793; 2:EgZkRwGpeIz2SCbZZbJzT4UvmYQhV8VMj80UDzRr1bMF91AcVJrcyYChkGaCJFlq; 3:lBUmOB94dJX8okIpmzBZDClhLqCzeMKXuhfsNB/9v/VE6P63lYMaMfRQof5jBaeXhrPYLPGzy+5xwXvf9YhQdVPDt3P3zsT5BGfldWjRW9qh87rB/zDv9S3pUwu8snJKocIY0c0czvDffXJ1cMJRgg==; 20:RbIy14QsrIWL/AJyFhWRLa2dwz5q/c9THOvCvPP779gJDJo87zvIP6iIrk3GNbDRVBUCsCBI5pvPZo1TccmIAQAcIGgiDa+yurmJSz6AOnvGG1GoEgboZYcy1rvPqVihXzLF/Uz3bCqELYve0lvtdtPYhJSKJ2FHtqYPduWXHTE=; 4:VG3OT6kmHAaOI8mxYG79MYWuo2UDiph7NltOC6+cFZoegroaCu3cMMFxYg16HgOS2exNSCpyWCP5Ur6NTgQRNotT4txHZD0aMJ4COJYZd/YVz+OZaQiJMjLvZ2OEO7fuMVTr/Vh1UkJfAyqQYqpuBXxUnqZ6nO5hR8BHGDcpDdSz7gTPXq/FvahJqyqdx14SNDcVGZQkrfZDd6SmfbGFKQJJxW2Gj3g2YQqdmpMCZC8KPdqfP0XL3NV8ccRbMmFfW3F848emncLrghmQBs70K1+Yw4FaeckqjB6OeRMx0LA= X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:HE1PR02MB0793; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(601004)(5005006)(3002001); SRVR:HE1PR02MB0793; BCL:0; PCL:0; RULEID:; SRVR:HE1PR02MB0793; X-Forefront-PRVS: 06157D541C X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(6009001)(377424004)(51704005)(52044002)(24454002)(50466002)(77156002)(62966003)(5001960100002)(76176999)(110136002)(189998001)(46406003)(122386002)(46102003)(19580405001)(40100003)(92566002)(47776003)(19580395003)(86362001)(66066001)(50986999)(42186005)(23726002)(50226001)(77096005)(2950100001)(33646002)(87976001)(107986001); DIR:OUT; SFP:1101; SCL:1; SRVR:HE1PR02MB0793; H:cchemparathy-ubuntu; FPR:; SPF:None; MLV:sfv; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; HE1PR02MB0793; 23:qW9meNDMBDTlG8j2YOl7bRS38rgYwNLSbHW2dtyNO1SmOH40yNyLPPc1wAmoGeEACxPHVQyKYzPej4qpbYWovXBzvJMg9mMJNGMoVXqFNVRpFUjqtbXCFdaTEysoSIsw8lBL+njZ2IJFj6YBhKW8EMOwVyaXfGzjqjf7YUgbvgzAKKo/Gn2aGCjqERIFBDjvwWH+zEE9DPySY0QxrmHHshGDx972DgsfgzInJUCCwZu9yZSKFvcp/3HUAUtkKhc2Uz2rHMIy9jk0hvgrtvtrG4WeY8NI1RXvvmGtcMXREJHZOO9WlLqq/kgvKC8Nx3pH6/7jgyxQPp0ffKrOolM07GSrO4IU37IsrYxUhF/6D3mcJFZQOD5CrTzGTvg0/ns4QXEmSIu6qKTnH7m7VrjKBNFHBVrRa3T/N2foiz+zUKl8zOT/2xIzyiFNiUS/SAp7ZDXE4abUrE26oT6UHczJNolcq756TVZWcbqFXZ7hjon0Cx0HJ7mTsFV2n1wwwFqYnmO/IiwRTEupXHxpD312zWG2GP20Yhz8S9e+/kaZTDn9kKpMoekWl+aFHQvpEzkRnfNImX0N/c2sTdMLffifPWfwmb7lBvWwQlVadZdmW1+yIjL5angdZ3mZV8t2kiWE6CTTweHFO3+3q/DuoOAuul41vcUeGLm4L+QJ/F3OckrkHZddTUNZKi5lM7VkoxeJuTm2r4/FD2UquyoVfZ8j83+GRZKXsRQhSmtk4YG0SqaZXR3rNQZ1J8wmxoCbvvPtX2VzaTdNeJxb9u+Ikfd7JHkvtVZSBi6n/hFY692HBrL5719WOVv/3B7sfTCI6QW0gXiPH9ShVk+oqYw4lhVShg== X-Microsoft-Exchange-Diagnostics: 1; HE1PR02MB0793; 5:dXxiKjG6Nk9nFGPrBoM7F3wuaurvjmdVjuOX80PNxGbWvnStadDArNwrXjLYPKyScj1sE/UmSpegBHY0Ze4UI12pVCU7w4oRhBt/7m/0xTqMB/xqwcTkH71ZX9hV+LWS1pM3STqZqoHIg6f/EPp2xQ==; 24:Q2RgCh37oT5llXedSA+86shsKDeBhiiWZ5TrJYMag7JQvviGuSPYa9Npw9xgGcbOSJ5Bo/AFvbSkx2mM8sCy00JamcgWJe6upd8rZQqXfpI=; 20:UZI92WH+Cc7S8HdF1hZbs9m+WxmfUF0BAEqE+y0WNLKbSYyVYX/3ZQ+2njirKVzjJ/mLg7F8NL9oD7j5r5MuKg== X-OriginatorOrg: ezchip.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Jun 2015 20:23:37.7261 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR02MB0793 Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH] lib: fix RTE_MBUF_METADATA macros X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 22 Jun 2015 20:23:41 -0000 On Mon, 22 Jun 2015 22:16:59 +0200 Thomas Monjalon wrote: > 2015-06-05 15:31, Dumitrescu, Cristian: > > > Fix RTE_MBUF_METADATA macros to allow for unaligned accesses to > > > meta-data fields. > > > Forcing aligned accesses is not really required, so this is > > > removing an unneeded constraint. > > > This issue was met during testing of the new version of the > > > ip_pipeline application. There is no performance impact. > > > This change has no ABI impact, as the previous code that uses > > > aligned accesses continues to run without any issues. > > > > > > Signed-off-by: Daniel Mrzyglod > > > > Ack-ed by: Cristian Dumitrescu > > Applied, thanks > > Cyril, feel free to fix it if it breaks with Tile arch. Why define these locally within rte_port.h? Shouldn't these macros really be in rte_mbuf.h?