From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from emea01-am1-obe.outbound.protection.outlook.com (mail-am1on0075.outbound.protection.outlook.com [157.56.112.75]) by dpdk.org (Postfix) with ESMTP id 3E7C9C6BA for ; Tue, 23 Jun 2015 22:43:23 +0200 (CEST) Authentication-Results: intel.com; dkim=none (message not signed) header.d=none; Received: from cchemparathy-ubuntu (12.218.212.162) by DB5PR02MB0790.eurprd02.prod.outlook.com (10.161.243.149) with Microsoft SMTP Server (TLS) id 15.1.195.15; Tue, 23 Jun 2015 20:43:20 +0000 Date: Tue, 23 Jun 2015 13:43:04 -0700 From: Cyril Chemparathy To: "Ananyev, Konstantin" Message-ID: <20150623134304.55c7233d@cchemparathy-ubuntu> In-Reply-To: <2601191342CEEE43887BDE71AB97725836A1CDB8@irsmsx105.ger.corp.intel.com> References: <1434999524-26528-1-git-send-email-cchemparathy@ezchip.com> <1434999524-26528-9-git-send-email-cchemparathy@ezchip.com> <2601191342CEEE43887BDE71AB97725836A1CDB8@irsmsx105.ger.corp.intel.com> Organization: EZchip X-Mailer: Claws Mail 3.11.1 (GTK+ 2.24.27; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Originating-IP: [12.218.212.162] X-ClientProxiedBy: CY1PR12CA0065.namprd12.prod.outlook.com (25.163.230.33) To DB5PR02MB0790.eurprd02.prod.outlook.com (25.161.243.149) X-Microsoft-Exchange-Diagnostics: 1; DB5PR02MB0790; 2:+5LKBC/whQyBz9rWKO1Ry+MjUXh3pp5L2M5IGl7yGq0dGzJWCahZ5PZn+pYPhx/a; 3:5BFIStdWm9EcVdYrJ20sVAHHJIH+Z2IcgqF5H1VCN+amUI68RQvN6Pn2GWJvaoM6pHTnE3fXb7yxBtJeRuW1GjlYQ3gpy36UQXIeXHKRNzKOrOMGwMQUianGrKbeBN4riZA9Xxdo67awVUFpxTY5qQ==; 20:svL/MwJ3NIMgLLi1yNSAqjqv6CgixVR4id0FjAZOxnjFH2YFk2CSAZjCk4dTOlay5mGzwa2378lfCY/CzwanrjOo0b4TsEQUE0gtuJFgjtZX5V8BbcdALOdJN94OVj1kQT3fIpHz9lS6o2BBRj+hGYDlmTlakI/BsZ7x2GoT6Gc=; 4:lFWGSm4pRKCWcWnLz6w62aAX6kUOTtf3Y+bZuBV00lRN/mr2SZNxVULODUAX7x+BdDFdD//43dXiuKRVssh1rd1JzyRFYhD0KqfekML/T9EYqpG8zEsPkmRdtd+bMwFQ3TD1MkIpQYfYDhqpVBY9uArNAdE1u30VMjCQPcyhvz/LPsHGcoCwsugY6x5XBUaQRbAx1rJZ1Sw+EJHYNF16jX7m5hZrZY9brIpiL63JtQZiCjoZqUQ4k957xB1exGDl/kEzU7qDFhWAxhRRfah6IOdW96o9EV52bjs9aVcK3/g= X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:DB5PR02MB0790; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(601004)(5005006)(3002001); SRVR:DB5PR02MB0790; BCL:0; PCL:0; RULEID:; SRVR:DB5PR02MB0790; X-Forefront-PRVS: 06167FAD59 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(6009001)(51704005)(24454002)(62966003)(110136002)(92566002)(50226001)(46102003)(77156002)(5001960100002)(33646002)(50466002)(50986999)(189998001)(40100003)(46406003)(23726002)(47776003)(42186005)(122386002)(87976001)(19580405001)(19580395003)(33716001)(86362001)(66066001)(77096005)(76176999)(2950100001)(107986001); DIR:OUT; SFP:1101; SCL:1; SRVR:DB5PR02MB0790; H:cchemparathy-ubuntu; FPR:; SPF:None; MLV:sfv; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; DB5PR02MB0790; 23:Mv0KkdsawTJxRptkmplULEPbhFs0jTnXsIAkJLP02DaHJ5aZyPmHsrK7szDwcHYLQh7pfKp+/mACElXgWBAIm+gJbDA++iTUMvHv5Lf8T58fXfukovTv0nUrMQ/dvGHUxQ+DPwkx4KuQEu+rJqfTfDJMJuPoIl3pCgfrO/d30Cbmv16CExQjr4HJFlK/2+q4oseT3tMfN4vPpVp9AOSwTPfVCJCJ4DeJxmzOUcMr8wrHLldltCZkPoxa97J58eAtpjBLA+6yXhCcfBsi527xZDZxE8JAp3hTnMdFQIvsylcjQ4cmrRK9v6MKO7y8qkU1pCNwksXqRCjXuEHi0KS9rceq3CQZYQNi/C/3H+kRaIW5I62kyLB4pgcqo/WDcMpZgzlrMajfRmdyW4LlfbkoYmlFbBReC24pr6KhQ/r1baWFwZBqmwdSyd0qW3KcgBpvSu7rmJQDlG2AbjziYsmTGJ1K/HCQBc3k7xeU7QewZhoX8IFPLVClUgXQjyZECktu8wks8kOCSox3eLpHxlTzJI8xi2Mfy9TfU5/g+GHDxT+lgKCTAk8NkoGJVDl5HSZYbVAFFcZ/mJg05DPGNJ3UlX46HVoPuP6pWOdJvjOkYgColJ89+T2VPCbSswqSr1EABiZlNRbr4dxOVfUa+BxSVMjLReVRq0XUyJb/8HPtpskTp2Wcvr3dzoXodAPJCKFRXmLuWK8+1R6nk7eAsFeodMxgyvYUKfu4YWxfw8m2G3pa58HHVzrbZY3nlAa9dlJlAXGW4J1nrrvJF5NreLiRuwhM4RoPrErVv7s5DsEZSK3ZFbpeum0sNr+RmwbOsTQK X-Microsoft-Exchange-Diagnostics: 1; DB5PR02MB0790; 5:AryHlJkcZXF04iOOGFcEBwYOPk74kDGDl4bS9U0mR0cjM4yDXmXwxDIHjlUHckvMRtWD8Xd0CrN/49d1X4T5ArYhexdEA04/9MaW++I4NRG5u/WBEOY5lTBegUNACo/IzKZEJSu16cN3sch7sdnj1A==; 24:FTEUJooRCHSy9yCI18zilJROXXHpDZxG1xKNcUW7TemR7eekLxqJRJ9H8zoyO5DlQ5JejajiJSc1enoUqnLvzhPAv5bk6Nq+WgCnyLWRyBw=; 20:kBmyoyWYvOMkv5w9psp7L80GZ0aPrYT51kOBK3XAYqTTxrkZSorIygXPm8O1/lOWa70Z0OUS7KsvzaQxMAN+Qw== X-OriginatorOrg: ezchip.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Jun 2015 20:43:20.1302 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB5PR02MB0790 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH v2 08/12] mempool: allow config override on element alignment X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 23 Jun 2015 20:43:23 -0000 On Tue, 23 Jun 2015 00:31:06 +0000 "Ananyev, Konstantin" wrote: > > +#define RTE_MEMPOOL_ALIGN_MASK (RTE_MEMPOOL_ALIGN - 1) > > I am probably a bit late with my comments, but why not make it a > runtime decision then? I know we can't add a new parameter to > mempool_xmem_create() without ABI breakage, but we can make some > global variable for now, that could be setup at init time or > something similar. But then, a global variable that is modified by an application _is_ a part of the ABI, and a bad one at that. I agree with the desire to make it runtime configurable, but I think we should do so in the right spirit, with the appropriate interfaces, and when we're open to changing the ABI accordingly. Thanks -- Cyril.