DPDK patches and discussions
 help / color / mirror / Atom feed
From: Matthew Hall <mhall@mhcomputing.net>
To: Vladimir Medvedkin <medvedkinv@gmail.com>
Cc: "<dev@dpdk.org>" <dev@dpdk.org>
Subject: Re: [dpdk-dev] rte_lpm with larger nexthops or another method?
Date: Tue, 23 Jun 2015 21:13:14 -0700	[thread overview]
Message-ID: <20150624041314.GA15524@mhcomputing.net> (raw)
In-Reply-To: <CANDrEHnh-cbT0ATSuvVjJ2xMyNL+tW+s3HY0f+=FSwpNF0uZNg@mail.gmail.com>

On Tue, Jun 23, 2015 at 10:19:58AM +0300, Vladimir Medvedkin wrote:
> Hi all,
> 
> Matthew,  I think ipv6 lpm code need less changes
> struct rte_lpm6_tbl_entry {
>         uint32_t next_hop:      21;  /**< Next hop / next table to be
> checked. */
>         uint32_t depth  :8;      /**< Rule depth. */
> 
>         /* Flags. */
>         uint32_t valid     :1;   /**< Validation flag. */
>         uint32_t valid_group :1; /**< Group validation flag. */
>         uint32_t ext_entry :1;   /**< External entry. */
> };
> there already is 21 bit for next_hop (need chenge only for rte_lpm6_rule)
> In Stephen approach for next_hop given only 16 bits, this is enough for
> next hop index, but not enough for AS number that originate prefix.
> 
> Regards,
> Vladimir

Vladimir,

One thing I was confused, you published the changes to rte_lpm_tbl24_entry but 
you didn't say what you did to change rte_lpm_tbl8_entry, as that one only had 
an 8-bit next_hop as well. I wanted to be sure I didn't change it wrong and 
break something.

Hopefully Stephen can make his bug fixes available so I could add all of this 
together and try to make a patchset for dpdk-next to test it all out. Would be 
a huge win compared to all the crappy LPM code I found on the Internet.

Matthew.

  reply	other threads:[~2015-06-24  4:15 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-22  2:29 Matthew Hall
2015-06-22 10:11 ` Vladimir Medvedkin
2015-06-22 17:53   ` Matthew Hall
2015-06-23  3:51     ` Stephen Hemminger
2015-06-23  6:30       ` Matthew Hall
2015-06-23  7:19         ` Vladimir Medvedkin
2015-06-24  4:13           ` Matthew Hall [this message]
2015-06-24  4:28             ` Matthew Hall
2015-06-24  5:15               ` Matthew Hall
2015-06-24  7:04                 ` Vladimir Medvedkin
2015-06-24 17:56                   ` Matthew Hall
2015-06-26  7:01                     ` Matthew Hall

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150624041314.GA15524@mhcomputing.net \
    --to=mhall@mhcomputing.net \
    --cc=dev@dpdk.org \
    --cc=medvedkinv@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).