From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <mhall@mhcomputing.net>
Received: from mail.mhcomputing.net (master.mhcomputing.net [74.208.46.186])
 by dpdk.org (Postfix) with ESMTP id AA040C564
 for <dev@dpdk.org>; Wed, 24 Jun 2015 06:31:36 +0200 (CEST)
Received: by mail.mhcomputing.net (Postfix, from userid 1000)
 id 99EAA80A264; Tue, 23 Jun 2015 21:28:59 -0700 (PDT)
Date: Tue, 23 Jun 2015 21:28:59 -0700
From: Matthew Hall <mhall@mhcomputing.net>
To: Vladimir Medvedkin <medvedkinv@gmail.com>
Message-ID: <20150624042859.GA16171@mhcomputing.net>
References: <5A3882CB-0DE0-43DB-8DCA-051D561AA943@mhcomputing.net>
 <CANDrEHnuEwX6WGBFbMiB0C38m6axMRiAe3z=9OcjsZkGbPZSSA@mail.gmail.com>
 <20150622175302.GA15788@mhcomputing.net>
 <20150622235102.41c3619a@uryu.home.lan>
 <20150623063024.GA3458@mhcomputing.net>
 <CANDrEHnh-cbT0ATSuvVjJ2xMyNL+tW+s3HY0f+=FSwpNF0uZNg@mail.gmail.com>
 <20150624041314.GA15524@mhcomputing.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20150624041314.GA15524@mhcomputing.net>
User-Agent: Mutt/1.5.23 (2014-03-12)
Cc: "<dev@dpdk.org>" <dev@dpdk.org>
Subject: Re: [dpdk-dev] rte_lpm with larger nexthops or another method?
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 24 Jun 2015 04:31:37 -0000

On Tue, Jun 23, 2015 at 09:13:14PM -0700, Matthew Hall wrote:
> Vladimir,
> 
> One thing I was confused, you published the changes to rte_lpm_tbl24_entry but 
> you didn't say what you did to change rte_lpm_tbl8_entry, as that one only had 
> an 8-bit next_hop as well. I wanted to be sure I didn't change it wrong and 
> break something.
> 
> Hopefully Stephen can make his bug fixes available so I could add all of this 
> together and try to make a patchset for dpdk-next to test it all out. Would be 
> a huge win compared to all the crappy LPM code I found on the Internet.
> 
> Matthew.

Another thing, this part errors out now. Not sure if it's just a performance warning or if it will break the code when I just comment it out... ;)

RTE_BUILD_BUG_ON(sizeof(struct rte_lpm_tbl24_entry) != 2);
RTE_BUILD_BUG_ON(sizeof(struct rte_lpm_tbl8_entry) != 2);

/vagrant/external/dpdk/lib/librte_lpm/rte_lpm.c:162:2: error: array size is negative
        RTE_BUILD_BUG_ON(sizeof(struct rte_lpm_tbl24_entry) != 2);
        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/vagrant/external/dpdk/build/include/rte_common.h:178:21: note: expanded from macro
      'RTE_BUILD_BUG_ON'
        ((void)sizeof(char[1 - 2*!!(condition)]));   \
                           ^~~~~~~~~~~~~~~~~~~
/vagrant/external/dpdk/lib/librte_lpm/rte_lpm.c:163:2: error: array size is negative
        RTE_BUILD_BUG_ON(sizeof(struct rte_lpm_tbl8_entry) != 2);
        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/vagrant/external/dpdk/build/include/rte_common.h:178:21: note: expanded from macro
      'RTE_BUILD_BUG_ON'
        ((void)sizeof(char[1 - 2*!!(condition)]));   \
                           ^~~~~~~~~~~~~~~~~~~

Matthew.