From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <stephen@networkplumber.org>
Received: from mail-pa0-f54.google.com (mail-pa0-f54.google.com
 [209.85.220.54]) by dpdk.org (Postfix) with ESMTP id D4EAAC966
 for <dev@dpdk.org>; Fri, 26 Jun 2015 18:51:52 +0200 (CEST)
Received: by pactm7 with SMTP id tm7so71249138pac.2
 for <dev@dpdk.org>; Fri, 26 Jun 2015 09:51:52 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to
 :references:mime-version:content-type:content-transfer-encoding;
 bh=kqUj25VbfGwH80jznH6zmVJjh374tsLafjb+e5TZs2g=;
 b=aHhmrmnHCupkSOn0cFYIp0nCEFuBMiTAn2src8URTtoiVWScTtf0x9sdmRDPJkQMLO
 bLoavhNRV3ufT9A4A9ruxPITugOxIQw82NRO9x+0EcaY3aoL0fzuZSFqlUjlh6S65FJQ
 9GVEDxwME1QgYBjZM18wXUlwqyVvQluQ7D0s8jNMTgoCUPcJlcbaUGK1twk6fiFxk+o4
 JYUrd/BF5Tr4GI00kwMrCkVLTl/LoQMVXnMGGYNmL5Gf6VbuXyHNW6yv+WHh99F47zQp
 D7p6KObnBU83Qi+KI8pN1Tg38PsmoLlU3+2xotbDWcPMr09cINxPZ99DbdsHdySr8Qxx
 9iUw==
X-Gm-Message-State: ALoCoQmZ8RG4NDVYyLCIsLq7MKSNwPSc6r1zMJehkTRza7kI7x2NZL5oRsPjBrgnNu/8e/+yehWO
X-Received: by 10.66.65.204 with SMTP id z12mr5304846pas.2.1435337512311;
 Fri, 26 Jun 2015 09:51:52 -0700 (PDT)
Received: from urahara (static-50-53-82-155.bvtn.or.frontiernet.net.
 [50.53.82.155])
 by mx.google.com with ESMTPSA id ve1sm33840179pbc.52.2015.06.26.09.51.51
 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Fri, 26 Jun 2015 09:51:51 -0700 (PDT)
Date: Fri, 26 Jun 2015 09:51:58 -0700
From: Stephen Hemminger <stephen@networkplumber.org>
To: Liang-Min Larry Wang <liang-min.wang@intel.com>
Message-ID: <20150626095158.4725a924@urahara>
In-Reply-To: <1435328807-15788-2-git-send-email-liang-min.wang@intel.com>
References: <1432946276-9424-1-git-send-email-liang-min.wang@intel.com>
 <1435328807-15788-1-git-send-email-liang-min.wang@intel.com>
 <1435328807-15788-2-git-send-email-liang-min.wang@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v8 1/5] ethdev: add apis to support access
 device info
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 26 Jun 2015 16:51:53 -0000

On Fri, 26 Jun 2015 10:26:43 -0400
Liang-Min Larry Wang <liang-min.wang@intel.com> wrote:

> add new apis:
> - rte_eth_dev_default_mac_addr_set
> - rte_eth_dev_reg_length
> - rte_eth_dev_reg_info
> - rte_eth_dev_eeprom_length
> - rte_eth_dev_get_eeprom
> - rte_eth_dev_set_eeprom
> 
> to enable reading device parameters (mac-addr, register,
> eeprom) based upon ethtool alike
> data parameter specification.
> 
> Signed-off-by: Liang-Min Larry Wang <liang-min.wang@intel.com>

I agree in principal, but has lots of style issues (see report from checkpatch).

ERROR: spaces required around that '=' (ctx:VxW)
#193: FILE: lib/librte_ether/rte_ethdev.c:3677:
+	if ((dev= &rte_eth_devices[port_id]) == NULL) {
 	        ^

ERROR: do not use assignment in if condition
#193: FILE: lib/librte_ether/rte_ethdev.c:3677:
+	if ((dev= &rte_eth_devices[port_id]) == NULL) {

ERROR: spaces required around that '=' (ctx:VxW)
#213: FILE: lib/librte_ether/rte_ethdev.c:3697:
+	if ((dev= &rte_eth_devices[port_id]) == NULL) {
 	        ^

ERROR: do not use assignment in if condition
#213: FILE: lib/librte_ether/rte_ethdev.c:3697:
+	if ((dev= &rte_eth_devices[port_id]) == NULL) {

ERROR: spaces required around that '=' (ctx:VxW)
#232: FILE: lib/librte_ether/rte_ethdev.c:3716:
+	if ((dev= &rte_eth_devices[port_id]) == NULL) {
 	        ^

ERROR: do not use assignment in if condition
#232: FILE: lib/librte_ether/rte_ethdev.c:3716:
+	if ((dev= &rte_eth_devices[port_id]) == NULL) {

ERROR: spaces required around that '=' (ctx:VxW)
#251: FILE: lib/librte_ether/rte_ethdev.c:3735:
+	if ((dev= &rte_eth_devices[port_id]) == NULL) {
 	        ^

ERROR: do not use assignment in if condition
#251: FILE: lib/librte_ether/rte_ethdev.c:3735:
+	if ((dev= &rte_eth_devices[port_id]) == NULL) {

ERROR: spaces required around that '=' (ctx:VxW)
#270: FILE: lib/librte_ether/rte_ethdev.c:3754:
+	if ((dev= &rte_eth_devices[port_id]) == NULL) {
 	        ^

ERROR: do not use assignment in if condition
#270: FILE: lib/librte_ether/rte_ethdev.c:3754:
+	if ((dev= &rte_eth_devices[port_id]) == NULL) {