DPDK patches and discussions
 help / color / mirror / Atom feed
From: Bruce Richardson <bruce.richardson@intel.com>
To: Daniel Mrzyglod <danielx.t.mrzyglod@intel.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v2] cfgfile: fix unitialised buffer
Date: Mon, 29 Jun 2015 15:33:52 +0100	[thread overview]
Message-ID: <20150629143352.GA11812@bricha3-MOBL3> (raw)
In-Reply-To: <1435587625-5096-1-git-send-email-danielx.t.mrzyglod@intel.com>

On Mon, Jun 29, 2015 at 04:20:25PM +0200, Daniel Mrzyglod wrote:
> Nature of the problem was not initialised buffer[256], there were probability
> that operation system will provide previously used memory and on special condition
> there were probability that string operations will work on random data that
> could provide unexpected program behaviour.
> 
> Signed-off-by: Daniel Mrzyglod <danielx.t.mrzyglod@intel.com>
> ---
>  lib/librte_cfgfile/rte_cfgfile.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/lib/librte_cfgfile/rte_cfgfile.c b/lib/librte_cfgfile/rte_cfgfile.c
> index b81c273..9c85e9f 100644
> --- a/lib/librte_cfgfile/rte_cfgfile.c
> +++ b/lib/librte_cfgfile/rte_cfgfile.c
> @@ -96,7 +96,10 @@ rte_cfgfile_load(const char *filename, int flags)
>  	int lineno = 0;
>  	struct rte_cfgfile *cfg = NULL;
>  
> +	memset(buffer, '\0', sizeof(buffer));
> +
>  	FILE *f = fopen(filename, "r");
> +
>  	if (f == NULL)
>  		return NULL;
>  
> -- 
> 2.1.0
> 
How about just adding "= {0}" to the end of the definition of buffer?

/Bruce

  reply	other threads:[~2015-06-29 14:33 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-26  8:37 [dpdk-dev] [PATCH] cfgfile: fix unitialised buffer and improve reading from nfs filesystem Daniel Mrzyglod
2015-06-26 14:05 ` Bruce Richardson
2015-06-29 14:20 ` [dpdk-dev] [PATCH v2] cfgfile: fix unitialised buffer Daniel Mrzyglod
2015-06-29 14:33   ` Bruce Richardson [this message]
2015-06-29 14:32 ` [dpdk-dev] [PATCH] cfgfile: fix unitialised buffer and improve reading from nfs filesystem Mrzyglod, DanielX T
2015-06-29 15:06 ` [dpdk-dev] [PATCH v3] cfgfile: fix unitialised buffer Daniel Mrzyglod
2015-06-29 19:47   ` Dumitrescu, Cristian
2015-07-01 21:36     ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150629143352.GA11812@bricha3-MOBL3 \
    --to=bruce.richardson@intel.com \
    --cc=danielx.t.mrzyglod@intel.com \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).