From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pd0-f171.google.com (mail-pd0-f171.google.com [209.85.192.171]) by dpdk.org (Postfix) with ESMTP id AEC775FEB for ; Tue, 30 Jun 2015 09:36:59 +0200 (CEST) Received: by pdbep18 with SMTP id ep18so1440023pdb.1 for ; Tue, 30 Jun 2015 00:36:59 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-type:content-transfer-encoding; bh=zZf1UhlD60Ej+I/16RcNvs70Iu9KZZM5eD4V2FxNRyQ=; b=aYcCpmrwNyfV8B/XzDqD/rpHwSKijyf/J1EhOVhbSDO6NTxlG6H8XZcFpSVFRMJbEp 19R4Ma4TSQFe0czf8ZYTXMEr6Nh1AxIGwzc11GUsu5OT2sf1ER9sfmHlNK1unmwRnit8 F25dvSU7y002uODqyzcn1B0ZbT5RmCb95xfiPxGhtArsaSVpNO31/swp9YVXwcpWAjhT KVP4TJuOt5NMm0Gy0ch9DfHtP3FnzMBa2rSupllPF6K/I8pqgGh2laGKcIILdL/+aDHw J3lTBUnIj/CfkXt6LJQwAihPAj/lxoX+cm8+eek7II0WlUv/DXWm8GcftK7Z4Zr1byhA kZBA== X-Gm-Message-State: ALoCoQkOoCa0i45GSCbieToeEeXWgGTGr3WqG+E0aTU7Bhs7O6HfyMdqyr2qtVeOcgBJamHOFjUP X-Received: by 10.70.49.73 with SMTP id s9mr40110674pdn.149.1435649819073; Tue, 30 Jun 2015 00:36:59 -0700 (PDT) Received: from uryu.home.lan (cpe-72-130-168-110.hawaii.res.rr.com. [72.130.168.110]) by mx.google.com with ESMTPSA id vx5sm40324314pbc.59.2015.06.30.00.36.57 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 30 Jun 2015 00:36:58 -0700 (PDT) Date: Mon, 29 Jun 2015 21:36:53 -1000 From: Stephen Hemminger To: "De Lara Guarch, Pablo" Message-ID: <20150629213653.5ba8388d@uryu.home.lan> In-Reply-To: References: <1433514804-7075-1-git-send-email-pablo.de.lara.guarch@intel.com> <1435269919-7007-1-git-send-email-pablo.de.lara.guarch@intel.com> <1435269919-7007-9-git-send-email-pablo.de.lara.guarch@intel.com> <20150626094955.4a999f79@urahara> X-Mailer: Claws Mail 3.11.1 (GTK+ 2.24.25; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH v2 08/11] hash: add new functionality to store data in hash table X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 30 Jun 2015 07:37:00 -0000 On Sun, 28 Jun 2015 22:23:28 +0000 "De Lara Guarch, Pablo" wrote: > Hi Stephen, > > > -----Original Message----- > > From: Stephen Hemminger [mailto:stephen@networkplumber.org] > > Sent: Friday, June 26, 2015 5:50 PM > > To: De Lara Guarch, Pablo > > Cc: dev@dpdk.org > > Subject: Re: [dpdk-dev] [PATCH v2 08/11] hash: add new functionality to > > store data in hash table > > > > We did same thing with a slightly different method. > > > > Subject: rte_hash: split key and bucket size > > > > It is useful to store more data in the has bucket than just the key size. > > For example, storing an addresss and additional data. > > > > Signed-off-by: Stephen Hemminger > > Did you send this patch? I did not see it in the mailing list... > Anyway, I like the idea of allowing the user to store variable size data (I was storing 8-byte data). > So I have sent a v3 with a more similar method, although I still use the new functions, > and use the parameter data_len for knowing the amount of bytes of data, and I keep constant the input key, > and return the data in another parameter. > > Thanks for it! > Pablo I did not send the patch upstream because it would break the ABI and didn't want to bother fighting that.