From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <bruce.richardson@intel.com>
Received: from mga11.intel.com (mga11.intel.com [192.55.52.93])
 by dpdk.org (Postfix) with ESMTP id 6B92E5A87
 for <dev@dpdk.org>; Tue, 30 Jun 2015 17:40:21 +0200 (CEST)
Received: from fmsmga002.fm.intel.com ([10.253.24.26])
 by fmsmga102.fm.intel.com with ESMTP; 30 Jun 2015 08:40:20 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.15,378,1432623600"; d="scan'208";a="753351553"
Received: from bricha3-mobl3.ger.corp.intel.com ([10.237.208.162])
 by fmsmga002.fm.intel.com with SMTP; 30 Jun 2015 08:40:17 -0700
Received: by  (sSMTP sendmail emulation); Tue, 30 Jun 2015 16:40:12 +0025
Date: Tue, 30 Jun 2015 16:40:12 +0100
From: Bruce Richardson <bruce.richardson@intel.com>
To: "Iremonger, Bernard" <bernard.iremonger@intel.com>
Message-ID: <20150630154011.GA6680@bricha3-MOBL3>
References: <1435546610-4533-9-git-send-email-mukawa@igel.co.jp>
 <1435652811-3487-1-git-send-email-mukawa@igel.co.jp>
 <1435652811-3487-2-git-send-email-mukawa@igel.co.jp>
 <8CEF83825BEC744B83065625E567D7C204A435E7@IRSMSX108.ger.corp.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <8CEF83825BEC744B83065625E567D7C204A435E7@IRSMSX108.ger.corp.intel.com>
Organization: Intel Shannon Ltd.
User-Agent: Mutt/1.5.23 (2014-03-12)
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v4] eal: Enable Port Hotplug as default in
	Linux and BSD
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 30 Jun 2015 15:40:21 -0000

On Tue, Jun 30, 2015 at 04:08:08PM +0100, Iremonger, Bernard wrote:
> 
> > -----Original Message-----
> > From: Tetsuya Mukawa [mailto:mukawa@igel.co.jp]
> > Sent: Tuesday, June 30, 2015 9:27 AM
> > To: dev@dpdk.org
> > Cc: Iremonger, Bernard; david.marchand@6wind.com; Richardson, Bruce;
> > Tetsuya.Mukawa
> > Subject: [PATCH v4] eal: Enable Port Hotplug as default in Linux and BSD
> > 
> > From: "Tetsuya.Mukawa" <mukawa@igel.co.jp>
> > 
> > This patch removes CONFIG_RTE_LIBRTE_EAL_HOTPLUG option, and enables
> > it as default in both Linux and BSD.
> > Also, to support port hotplug, rte_eal_pci_scan() and below missing symbols
> > should be exported to ethdev library.
> >  - rte_eal_parse_devargs_str()
> >  - rte_eal_pci_close_one()
> >  - rte_eal_pci_probe_one()
> >  - rte_eal_pci_scan()
> >  - rte_eal_vdev_init()
> >  - rte_eal_vdev_uninit()
> > 
> > Signed-off-by: Tetsuya Mukawa <mukawa@igel.co.jp>
> 
> Hi Tetsuya,
> 
> Would it be cleaner to add this patch to the  [PATCH  v7 12/12] patch set as  patch 13 rather than having it as a separate patch?
>
The other patch set is cleanup, merging BSD and Linuxapp code, so I think it's
best kept as a separate set. New features I'd suggest keeping separate from
cleanup. 
That being said, it is only one patch, so it probably doesn't matter much either
way. :-)

/Bruce