From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <bruce.richardson@intel.com>
Received: from mga03.intel.com (mga03.intel.com [134.134.136.65])
 by dpdk.org (Postfix) with ESMTP id 5DD4411F5
 for <dev@dpdk.org>; Thu,  2 Jul 2015 13:11:15 +0200 (CEST)
Received: from fmsmga001.fm.intel.com ([10.253.24.23])
 by orsmga103.jf.intel.com with ESMTP; 02 Jul 2015 04:11:12 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.15,392,1432623600"; d="scan'208";a="739185206"
Received: from bricha3-mobl3.ger.corp.intel.com ([10.237.208.61])
 by fmsmga001.fm.intel.com with SMTP; 02 Jul 2015 04:11:10 -0700
Received: by  (sSMTP sendmail emulation); Thu, 02 Jul 2015 12:11:09 +0025
Date: Thu, 2 Jul 2015 12:11:09 +0100
From: Bruce Richardson <bruce.richardson@intel.com>
To: Tetsuya Mukawa <mukawa@igel.co.jp>
Message-ID: <20150702111109.GD3828@bricha3-MOBL3>
References: <1435306705-11645-4-git-send-email-mukawa@igel.co.jp>
 <1435652668-3380-1-git-send-email-mukawa@igel.co.jp>
 <1435652668-3380-10-git-send-email-mukawa@igel.co.jp>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1435652668-3380-10-git-send-email-mukawa@igel.co.jp>
Organization: Intel Shannon Ltd.
User-Agent: Mutt/1.5.23 (2014-03-12)
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v7 09/12] eal: Consolidate
 pci_map/unmap_resource() of linuxapp and bsdapp
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 02 Jul 2015 11:11:17 -0000

On Tue, Jun 30, 2015 at 05:24:25PM +0900, Tetsuya Mukawa wrote:
> From: "Tetsuya.Mukawa" <mukawa@igel.co.jp>
> 
> The patch consolidates below functions, and implemented in common
> eal code.
>  - pci_map_resource()
>  - pci_unmap_resource()
> 
> Signed-off-by: Tetsuya Mukawa <mukawa@igel.co.jp>
> ---
>  lib/librte_eal/bsdapp/eal/eal_pci.c        | 22 ----------------
>  lib/librte_eal/common/eal_common_pci.c     | 39 ++++++++++++++++++++++++++++
>  lib/librte_eal/common/include/rte_pci.h    | 11 ++++++++
>  lib/librte_eal/linuxapp/eal/eal_pci.c      | 41 ------------------------------
>  lib/librte_eal/linuxapp/eal/eal_pci_init.h |  5 ----
>  5 files changed, 50 insertions(+), 68 deletions(-)
>
<snip>
> diff --git a/lib/librte_eal/common/include/rte_pci.h b/lib/librte_eal/common/include/rte_pci.h
> index 0a2ef09..56dcb46 100644
> --- a/lib/librte_eal/common/include/rte_pci.h
> +++ b/lib/librte_eal/common/include/rte_pci.h
> @@ -364,6 +364,17 @@ int rte_eal_pci_scan(void);
>   */
>  int rte_eal_pci_probe(void);
>  
> +/**
> + * Map pci resouce.
> + */
> +void *pci_map_resource(void *requested_addr, int fd, off_t offset,
> +		size_t size, int additional_flags);
> +
> +/**
> + * Map pci resouce.
> + */
> +void pci_unmap_resource(void *requested_addr, size_t size);
> +

These functions should probably be marked "@internal", right?