From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 8EFF6E62 for ; Fri, 3 Jul 2015 11:45:56 +0200 (CEST) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga103.fm.intel.com with ESMTP; 03 Jul 2015 02:45:55 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.15,399,1432623600"; d="scan'208";a="722308128" Received: from bricha3-mobl3.ger.corp.intel.com ([10.237.208.62]) by orsmga001.jf.intel.com with SMTP; 03 Jul 2015 02:45:49 -0700 Received: by (sSMTP sendmail emulation); Fri, 03 Jul 2015 10:45:47 +0025 Date: Fri, 3 Jul 2015 10:45:47 +0100 From: Bruce Richardson To: Tetsuya Mukawa Message-ID: <20150703094547.GA7548@bricha3-MOBL3> References: <1435306705-11645-4-git-send-email-mukawa@igel.co.jp> <1435652668-3380-1-git-send-email-mukawa@igel.co.jp> <1435652668-3380-7-git-send-email-mukawa@igel.co.jp> <20150702104637.GC3828@bricha3-MOBL3> <55964D3B.6020507@igel.co.jp> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <55964D3B.6020507@igel.co.jp> Organization: Intel Shannon Ltd. User-Agent: Mutt/1.5.23 (2014-03-12) Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v7 06/12] eal: Add pci_uio_alloc_resource() X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 03 Jul 2015 09:45:57 -0000 On Fri, Jul 03, 2015 at 05:52:11PM +0900, Tetsuya Mukawa wrote: > On 2015/07/02 19:46, Bruce Richardson wrote: > > On Tue, Jun 30, 2015 at 05:24:22PM +0900, Tetsuya Mukawa wrote: > >> From: "Tetsuya.Mukawa" > >> > >> This patch adds a new function called pci_uio_alloc_resource(). > >> The function hides how to prepare uio resource in linuxapp and bsdapp. > >> With the function, pci_uio_map_resource() will be more abstracted. > >> > >> Signed-off-by: Tetsuya Mukawa > >> --- > >> lib/librte_eal/bsdapp/eal/eal_pci.c | 70 +++++++++++++++++++--------- > >> lib/librte_eal/linuxapp/eal/eal_pci_uio.c | 77 ++++++++++++++++++++++--------- > >> 2 files changed, 104 insertions(+), 43 deletions(-) > >> > >> diff --git a/lib/librte_eal/bsdapp/eal/eal_pci.c b/lib/librte_eal/bsdapp/eal/eal_pci.c > >> index 06c564f..7d2f8b5 100644 > >> --- a/lib/librte_eal/bsdapp/eal/eal_pci.c > >> +++ b/lib/librte_eal/bsdapp/eal/eal_pci.c > >> @@ -189,28 +189,17 @@ pci_uio_map_secondary(struct rte_pci_device *dev) > >> return 1; > >> } > >> > >> -/* map the PCI resource of a PCI device in virtual memory */ > >> static int > >> -pci_uio_map_resource(struct rte_pci_device *dev) > >> +pci_uio_alloc_resource(struct rte_pci_device *dev, > >> + struct mapped_pci_resource **uio_res) > > Rather than having to pass in a pointer to a pointer, why not change the > > return type to be "struct mapped_pci_resource *"? The only return values currently > > are 0 and -1, so those could map to non-NULL and NULL respectively, for error > > checking. > > > > /Bruce > > It might be difficult to do like above, because pci_uio_alloc_resource() > returns 0, -1 and 1 as return value so far. > > Original pci_uio_map_resource() returns negative return value as error, > and positive value as driver not found. > So I follow this specification while implementing the function. > > Tetsuya Ok. Keep it as is, so. /Bruce