From: Stephen Hemminger <stephen@networkplumber.org>
To: David Marchand <david.marchand@6wind.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, Stephen Hemminger <shemming@Brocade.com>
Subject: Re: [dpdk-dev] [PATCH 1/4] eal: provide functions to access PCI config
Date: Thu, 9 Jul 2015 14:08:32 -0700 [thread overview]
Message-ID: <20150709140832.570e77f3@urahara> (raw)
In-Reply-To: <513c51e29ab6449c99ae70c77e72566c@BRMWP-EXMB11.corp.brocade.com>
On Wed, 17 Jun 2015 14:44:31 +0000
David Marchand <david.marchand@6wind.com> wrote:
> + if (len == 3 || len > sizeof(pi.pi_data)) {
> + RTE_LOG(ERR, EAL, "%s(): invalid pci read length\n", __func__);
> + goto error;
> + }
>
> A comment on length 3 would help to understand why it is refused.
PCI only supports 1, 2, and 4 byte transactions.
Hopefully someone using this would understand that.
next prev parent reply other threads:[~2015-07-09 21:08 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-16 23:51 [dpdk-dev] [PATCH 0/4 v5] bnx2x: poll mode driver Stephen Hemminger
2015-06-16 23:51 ` [dpdk-dev] [PATCH 1/4] eal: provide functions to access PCI config Stephen Hemminger
2015-06-17 7:31 ` Panu Matilainen
2015-06-17 14:44 ` David Marchand
[not found] ` <513c51e29ab6449c99ae70c77e72566c@BRMWP-EXMB11.corp.brocade.com>
2015-07-09 21:08 ` Stephen Hemminger [this message]
2015-06-16 23:51 ` [dpdk-dev] [PATCH 2/4] bnx2x: driver core Stephen Hemminger
2015-06-16 23:51 ` [dpdk-dev] [PATCH 3/4] bnx2x: driver support routines Stephen Hemminger
2015-06-16 23:51 ` [dpdk-dev] [PATCH 4/4] bnx2x: enable PMD build Stephen Hemminger
2015-06-17 11:19 ` Yotam Rubin
2015-06-26 0:57 ` [dpdk-dev] [PATCH 0/4 v5] bnx2x: poll mode driver Harish Patil
2015-07-02 12:53 ` Thomas Monjalon
2015-07-08 0:08 [dpdk-dev] [PATCH v3 0/4] " Stephen Hemminger
2015-07-08 0:08 ` [dpdk-dev] [PATCH 1/4] eal: provide functions to access PCI config Stephen Hemminger
2015-07-08 15:04 ` Thomas Monjalon
[not found] ` <d35efa226d95495e804181b2246063d2@HQ1WP-EXMB11.corp.brocade.com>
2015-07-08 16:11 ` Stephen Hemminger
2015-07-08 16:34 ` Thomas Monjalon
2015-07-09 18:15 [dpdk-dev] [PATCH v4 0/4] bnx2x: new poll mode driver Stephen Hemminger
2015-07-09 18:15 ` [dpdk-dev] [PATCH 1/4] eal: provide functions to access PCI config Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150709140832.570e77f3@urahara \
--to=stephen@networkplumber.org \
--cc=david.marchand@6wind.com \
--cc=dev@dpdk.org \
--cc=shemming@Brocade.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).