From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <stephen@networkplumber.org>
Received: from mail-pd0-f171.google.com (mail-pd0-f171.google.com
 [209.85.192.171]) by dpdk.org (Postfix) with ESMTP id 0D70C5A68
 for <dev@dpdk.org>; Thu,  9 Jul 2015 23:08:24 +0200 (CEST)
Received: by pdrg1 with SMTP id g1so39575759pdr.2
 for <dev@dpdk.org>; Thu, 09 Jul 2015 14:08:23 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to
 :references:mime-version:content-type:content-transfer-encoding;
 bh=ey9sbh+sqRS4oI9by3ei0chR2KrHJq6/e1mIPbP/SwQ=;
 b=YK/0kLvAdPAuDc2LHYkiDvJsr98gqIF+4pE3Ih4UQfYh/qtHBdfuy0FJWJEQhZwPJ0
 HxIkLAOSyjd4213hFM3TFA/I7Z06yUWeI2GyCs+J3sOy1zlPr5JdXdeNDnSPd/jbK00K
 GhpniyBmekkGuQrSuzt1FcOHUjOwl/p1DiQYnlNr1A59hCQY5WLhYU3V0k2o3Rb7HWdc
 j5jPM6mqdIFG4U81Uexx2/KcI/VUR3npmRVAYViVArI/qSA9HwSWT0GHgzOCARmVLPwy
 7W+9PWUUH4tBzGf70LbMIKveAr5IKCqhEumBYw39bVyHNiWr/FbBSIz4wwSaDDgN00P2
 +wGQ==
X-Gm-Message-State: ALoCoQkPyI5sxP6o5mR42Gz2TjGmVoHktgF8lyNcSIWt57jjPDuwpKbzPIdd9hQNWLo6js+jWuQu
X-Received: by 10.66.141.5 with SMTP id rk5mr21861263pab.16.1436476103215;
 Thu, 09 Jul 2015 14:08:23 -0700 (PDT)
Received: from urahara (static-50-53-82-155.bvtn.or.frontiernet.net.
 [50.53.82.155])
 by smtp.gmail.com with ESMTPSA id k3sm6975778pde.18.2015.07.09.14.08.22
 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Thu, 09 Jul 2015 14:08:22 -0700 (PDT)
Date: Thu, 9 Jul 2015 14:08:32 -0700
From: Stephen Hemminger <stephen@networkplumber.org>
To: David Marchand <david.marchand@6wind.com>
Message-ID: <20150709140832.570e77f3@urahara>
In-Reply-To: <513c51e29ab6449c99ae70c77e72566c@BRMWP-EXMB11.corp.brocade.com>
References: <1434498700-8522-1-git-send-email-stephen@networkplumber.org>
 <1434498700-8522-2-git-send-email-stephen@networkplumber.org>
 <513c51e29ab6449c99ae70c77e72566c@BRMWP-EXMB11.corp.brocade.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Cc: "dev@dpdk.org" <dev@dpdk.org>, Stephen Hemminger <shemming@Brocade.com>
Subject: Re: [dpdk-dev] [PATCH 1/4] eal: provide functions to access PCI
 config
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 09 Jul 2015 21:08:24 -0000

On Wed, 17 Jun 2015 14:44:31 +0000
David Marchand <david.marchand@6wind.com> wrote:

> +=C2=A0 =C2=A0 =C2=A0 =C2=A0if (len =3D=3D 3 || len > sizeof(pi.pi_data))=
 {
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0RTE_LOG(ERR, EAL,=
 "%s(): invalid pci read length\n", __func__);
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0goto error;
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0}
>=20
> A comment on length 3 would help to understand why it is refused.


PCI only supports 1, 2, and 4 byte transactions.
Hopefully someone using this would understand that.