From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pd0-f170.google.com (mail-pd0-f170.google.com [209.85.192.170]) by dpdk.org (Postfix) with ESMTP id DB11C5A96 for ; Fri, 10 Jul 2015 01:03:28 +0200 (CEST) Received: by pdjr16 with SMTP id r16so11514486pdj.3 for ; Thu, 09 Jul 2015 16:03:28 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-type:content-transfer-encoding; bh=n15GITfAuCVEsnuIJ6C4tPxsEe/L6f7r7hJwF8CskdM=; b=lRoSUkG1tHJ9YdIY5Bz92KzPiS12se5rr8dbHz5rzfOUp1j1rpXlwKZ3PSAy0DL6P8 GcKwN9zO1g/aNp4ZPV1GG7nYR/o6qJX0lz4HDRoVRTRb5Mic0lAuFnHBoGfeZmcPi/uH //egUYlvNGZaeGL/xeKBLCSrP+41s1nGurgn1/rTyi30U7Lu06jjUYHPXPvjLT1ebnDH vwaQTFaT/5cbgEugPgcCGIoHko3q3JCUqkFrF8S6q+4EpsChRerXB127gL6KpkOlRoZI 1FDas/x/fFbopOllSGImVNewV+xbi6jh5+jgfm2puzhR9aAhbK9kUIY/xUmQSYWJozJL FBnw== X-Gm-Message-State: ALoCoQkm0/BnZyRhCi1y9KWZF/3sgGdoXi8WKEYqeQ5R4p2/tXNZBOVi+B8cA57VqKMAR9vcWus5 X-Received: by 10.68.181.163 with SMTP id dx3mr35241044pbc.5.1436483008299; Thu, 09 Jul 2015 16:03:28 -0700 (PDT) Received: from urahara (static-50-53-82-155.bvtn.or.frontiernet.net. [50.53.82.155]) by smtp.gmail.com with ESMTPSA id ky17sm536899pab.31.2015.07.09.16.03.27 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 09 Jul 2015 16:03:28 -0700 (PDT) Date: Thu, 9 Jul 2015 16:03:37 -0700 From: Stephen Hemminger To: Thomas Monjalon Message-ID: <20150709160337.3ba72cae@urahara> In-Reply-To: <1556408.e2XOMCRvgs@xps13> References: <2601191342CEEE43887BDE71AB977258214074F6@irsmsx105.ger.corp.intel.com> <1556408.e2XOMCRvgs@xps13> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: dev@dpdk.org, Stephen Hemminger Subject: Re: [dpdk-dev] [PATCH] ixgbe: do not include CRC in Tx byte count X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 09 Jul 2015 23:03:29 -0000 On Wed, 01 Apr 2015 09:45:02 +0200 Thomas Monjalon wrote: > 2015-03-24 23:54, Ananyev, Konstantin: > > From: Stephen Hemminger [mailto:stephen@networkplumber.org] > > > On Mon, 23 Mar 2015 16:45:44 +0000 > > > "Ananyev, Konstantin" wrote: > > > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of stephen@networkplumber.org > > > > > From: Stephen Hemminger > > > > > > > > > > The ixgbe driver was including CRC in the transmit packet byte > > > > > count, but not for packets received. > > > > > This was notice when forwarding and > > > > > the number of bytes received was greater than the number of bytes transmitted > > > > > for the same number of packets. Make the driver behave like other > > > > > virtual devices and not include CRC in byte count. Use the same queue > > > > > counters already computed and used for Rx. > > > > > > > > About RX side stats - as I remember it depends to what value hw_stip_crc is set at configure(). > > > > If hw_stip_crc==1, then, yes CRC bytes are not included into QBRC value. > > > > I If hw_stip_crc==0, then CRC bytes are included into QBRC. > > > > > > That is an additional bug! > > > * CRC should never be included in the byte count. > > > This is not how Linux or other drivers report byte count. > > > > I don't have any strong opinion here... > > For me any method (with or without CRC) of counting bytes are ok, as long as this method is identical across all PMDs we support. > > Which makes we wonder, what approach other PMDs use? > > > > > > > > * the byte count must be symmetrical Rx == Tx > > > > > > The Brocade router always set strip_crc to 1. So did not see the additional bug > > > of CRC being included in byte count. > > > > Are you going to submit v2, to make Rx==Tx for both cases? > > Any conclusion? > Without update, this patch is going to be dropped. My conclusion was that CRC should never be in byte count regardless of configuration because that is what everyone (except CISCO) expects. My patch did that.